[ZBX-3972] Add "Ok" button to zabbix calendar Created: 2011 Jul 20 Updated: 2017 May 30 Resolved: 2011 Aug 05 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | 1.8.5, 1.9.5 (alpha) |
Fix Version/s: | 1.8.7 |
Type: | Incident report | Priority: | Major |
Reporter: | Oleksii Zagorskyi | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Attachments: | calendar.png proposed_buttons_position.png proposed_ok_button.png |
Description |
I recall first time when i used calendar I could not understand what i need to do to change selected time period in the calendar. I thought - why there is no Ok button? Many of similar calendars have Ok button and it's intuitively understandable that i need to click Ok after changing something manually. All this time every time when i used calendar (for change hours or minutes) i feel the same - where is damn Ok button? Additionally is not intuitively understandable what i need to click for close calendar when i open it accidentally. Ok button can be very useful for such cases. I think (i hope) i'm not alone and i propose to add this button. See attached picture. |
Comments |
Comment by Igor Danoshaites (Inactive) [ 2011 Jul 21 ] |
Hi Oleksiy, I agree with you, it is not intuitively understandable. I also think that "OK" button is required there. |
Comment by Eduards Samersovs (Inactive) [ 2011 Jul 21 ] |
Added "Now" and "Done" buttons. |
Comment by Oleksii Zagorskyi [ 2011 Jul 21 ] |
Eduards, i tested dev branche. And i hope for 2.0 buttons will have a another style? or even for 1.8 the style should be harmonious with GUI?. |
Comment by Eduards Samersovs (Inactive) [ 2011 Jul 22 ] |
Oleksiy, check dev branche. Now it's look like in "calendar.png" |
Comment by Oleksii Zagorskyi [ 2011 Jul 22 ] |
Eduards, firstly, thanks for fast implementation ! And i'm thinking - maybe "Now" button should close the calendar immediately? i.e. - we do not need to click "Done" after "Now" |
Comment by Oleksii Zagorskyi [ 2011 Jul 22 ] |
Additionally to my previous post - or maybe calendar should not closes after click to date, and only after click to Done? I don't know what is better for usability. |
Comment by richlv [ 2011 Jul 22 ] |
my suggestions : 1. move buttons on the same line as time input fields, remove "Time" title (it is helpful, but breaks layout too much, and those fields seem to be intuitively understandable. additionally, we don't have "year", "month" or "date" titles ) 2. do not close calendar when clicking either on date or "now" otherwise, this should be a small but really nice usability improvement for the calendar |
Comment by Oleksii Zagorskyi [ 2011 Jul 22 ] |
Take a look at the hacked "proposed_buttons_position.png" |
Comment by Eduards Samersovs (Inactive) [ 2011 Jul 25 ] |
Buttons “Now” and “Done” are located in a separate line because after translation into other languages it can arise situation that text will exceed the scope. For example in russian Now can be translated as “Сейчас”, Done as “Подтвердить” or “Завершить”.. |
Comment by Oleksii Zagorskyi [ 2011 Jul 25 ] |
Eduards, good point, but, i already thought about that I have a huge experience for similar translation "troubleshooting" for two languages. But sometimes (as for this case) we (translators) don't have other choice then discard such rule and we are doing a NOT literal translation or shortening. And it's not so scary. And now i want last time to ask - why you do not want to use "Ok" text (as i suggest from the beginning)? This word translated as is for all languages, and we will not have any problems with the place for translation word "Now". Additionally i want to take your attention to my previous suggestion to move "Now" on top. For instance place it under "Months" selector with the same style as for Moths, Years. I see that logical. Then we can use "Done" (if you really want it) button without any problems for translation. Sorry, too many text, but i would like to share my opinion |
Comment by richlv [ 2011 Jul 25 ] |
good point on translation lengths. maybe the popup could stretch horizontally in that case ? (but do that in a not too ugly way ) |
Comment by Eduards Samersovs (Inactive) [ 2011 Aug 05 ] |
branche/1.8 revision 20954 |