[ZBX-4023] excess spacing and useless "plural" in graph deletion message Created: 2011 Aug 08  Updated: 2017 May 30  Resolved: 2011 Aug 08

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.6
Fix Version/s: 1.8.7

Type: Incident report Priority: Minor
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Graph " Used diskspace " deleted from host : "Zabbix server"

S_GRAPH_DELETED_FROM_HOSTS_PART2.SPACE.(count($host_list[$graphid]) > 1 ? 's' : '')



 Comments   
Comment by richlv [ 2011 Aug 08 ]

improved in dev branch svn://svn.zabbix.com/branches/dev/ZBX-4023

an excess space before colon is still possible and plurals are not handled at all, but it must be fixed properly in trunk, trying to keep 1.8 changes minimal

edit : actually, looks like trunk doesn't have this problem anymore

Comment by Eduards Samersovs (Inactive) [ 2011 Aug 10 ]

(1) info(S_GRAPH_DELETED_FROM_HOSTS_PART1.$graph['name'].S_GRAPH_DELETED_FROM_HOSTS_PART2.SPACE.S_GRAPH_DELETED_FROM_HOSTS_PART3.':'.SPACE.'"'.implode('","', array_keys($host_list[$graphid])).'"');

it will be better remove S_GRAPH_DELETED_FROM_HOSTS_PART3 constant

<richlv> S_GRAPH_DELETED_FROM_HOSTS_PART3 may be used by languages where sentence construct is different - for example, it is currently used in japanese translation
WON'T FIX

<Eduard> S_GRAPH_DELETED_FROM_HOSTS_PART2 and S_GRAPH_DELETED_FROM_HOSTS_PART3 is used only in this graphs.inc.php and only in this line.
Maybe we can edit S_GRAPH_DELETED_FROM_HOSTS_PART2 (if necessary) and remove S_GRAPH_DELETED_FROM_HOSTS_PART3?

<richlv> thanks, merged part3 into part2 for japanese & removed part in dev branch rev 21063.
RESOLVED

<Eduard> CLOSED

Comment by Kodai Terashima [ 2011 Aug 10 ]

PART3 is needed for Japanese, but it is not needed for other language.

In addition, the order of words are different in Japanese.

In English: Graph XXX is deleted from hosts YYY.
In Japanese: Graph XXX is hosts YYY from deleted.

So, I think following approach is better than now for ALL language.

'S_GRAPH_DELETED_FROM_HOSTS' => ''Graph "%1$s" deleted from host "%2$s"

This approach is same as S_GRAPH_ALREADY_EXISTS_ON which is added Zabbix 1.8.6.

Comment by richlv [ 2011 Aug 10 ]

merged to 1.8 branch in rev 21066.
won't be merged to trunk, no such message there

Generated at Thu Mar 28 18:40:51 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.