[ZBX-4038] maximum number of days to keep history and trends for Created: 2011 Aug 11  Updated: 2017 May 30  Resolved: 2012 Mar 27

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.6
Fix Version/s: 2.0.0rc3

Type: Incident report Priority: Minor
Reporter: Aleksandrs Saveljevs Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: items, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Suppose we wish to keep history and trends forever. In that case, we wish to enter the maximum value into "Keep history" and "Keep trends" fields in item configuration. However, it is unclear what the maximum value is.

It turns out that the maximum value is 65535 days (by the way, why?), but it would be nice if the GUI would help the user to find that value. Currently, it allows to enter an eight digit number into both fields and then complains:

  • Warning. Incorrect value for [history]
  • Warning. Incorrect value for [trends]

 Comments   
Comment by Aleksandrs Saveljevs [ 2011 Aug 16 ]

Same problem for "Refresh unsupported items (in sec)" configuration parameter in "Administration" -> "General" -> "Other".

Comment by Toms (Inactive) [ 2012 Mar 15 ]

Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBX-4038

Comment by Alexey Fukalov [ 2012 Mar 16 ]

This should be somehow done without passing error messages as parameter to "check_fields" function.

<Toms> RESOLVED in r26162

Comment by Alexey Fukalov [ 2012 Mar 19 ]

(1)
I think there is unused code left in validate.inc.php for $caption2.
Check for range numbers can be done with one regexp instead of two.
Translation strings shouldn't be separated.

<Toms> RESOLVED in r26272

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 19 ]

(2)
In graphs.php ZBX_MN_WIDTH is used for both width and height, and tbh i don't like constant name, as it's too general.

<Toms> RESOLVED in r26272

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 19 ]

(3)
At some places numbers were changed to constants at some were not.
Also different constants should be used for different fields.

<Toms> Point them out please.

<Toms> We came to agreement that constants will be added later. RESOLVED in r26272

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 19 ]

(4)
Nice error message is shown only for "warnings" probably should be same for "criticals".

<Toms> RESOLVED in r26272

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 19 ]

(5)
Also it should work even if between check is combined with with other checks i.e. regexp should not match whole string only.

<Toms> RESOLVED in r26272

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 19 ]

Also sync with trunk please, there are some conflicts.

<Toms> RESOLVED in r26272

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 26 ]

(6)
Seems wrong lines were removed in nodes.php after merge.

Comment by Alexey Fukalov [ 2012 Mar 26 ]

(7)
in chart7.php "BETWEEN(_PERIOD,ZBX_MAX_PERIOD),"
Same in chart6.php, chart3.php, chart2.php, chart.php and more..

Comment by Alexey Fukalov [ 2012 Mar 26 ]

(8)
Use of undefined constant _PORT_NUMBER - assumed '_PORT_NUMBER' [include/validate.inc.php:616]
Incorrect interface port "10050" provided. [CHost.update -> CHostInterface.replaceHostInterfaces -> CHostInterface.checkInput]

When update host.

Comment by Toms (Inactive) [ 2012 Mar 27 ]

RESOLVED from fresh start: svn://svn.zabbix.com/branches/dev/ZBX-4038-2

Comment by Alexey Fukalov [ 2012 Mar 27 ]

(9)
Parse error: syntax error, unexpected ';', expecting ')' in /home/vedmak/public_html/trunk1/frontends/php/items.php on line 194

When open items list.

<Toms> RESOLVED in r26423

<Vedmak> CLOSED

Comment by Toms (Inactive) [ 2012 Mar 28 ]

Fixed in 2.0.0rc3 r26425

Generated at Sat Apr 20 02:55:20 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.