[ZBX-4333] Not adding triggers dependencies from template Created: 2011 Nov 08 Updated: 2017 May 30 Resolved: 2012 Mar 07 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | 1.8.8, 1.8.9rc2, 1.9.8 (beta) |
Fix Version/s: | 1.8.11, 2.0.0rc1 |
Type: | Incident report | Priority: | Blocker |
Reporter: | Oleksii Zagorskyi | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | dependencies, triggers | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Attachments: | triggers.jpg | ||||
Issue Links: |
|
Description |
This issue is the same as We have two templates with one trigger per every template where one is the dependency for another. |
Comments |
Comment by richlv [ 2011 Nov 21 ] |
still the same in 1.8.9rc2 |
Comment by richlv [ 2012 Jan 17 ] |
(1) changes in rev 24828 violate coding style guidelines <richlv> if statement indentation seems to be still broken, it's spacing is broken as well (after all, that line was modified...) and sql statement still has excess spaces between arguments. there might be other things not listed here. <Sasha> An update_template_dependencies_for_host() function is not used anywhere; a commented code should be removed <pavels> More coding style fixes in r25011, please review. <Sasha> CLOSED |
Comment by Alexander Vladishev [ 2012 Jan 18 ] |
(2) when linking a template to a host, host triggers depends on template triggers <pavels> No it wasn't. RESOLVED in r25038. |
Comment by richlv [ 2012 Jan 20 ] |
(3) rev 24923 - typo in the changelog entry <pavels> CLOSED. |
Comment by Alexander Vladishev [ 2012 Jan 23 ] |
(4) dependencies aren't copied in operation "Copy selected to ..." <pavels> RESOLVED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Jan 26 ] |
(5) When linking a template with a dependency on a different template, an empty error line appears: Trigger in template [ template ] has dependency with trigger in template [ template2 ] Cannot link template <pavels> RESOLVED. |
Comment by Alexander Vladishev [ 2012 Jan 30 ] |
(6) when copying trigger from host to another host there are superfluous actions with DB: ..... <pavels> RESOLVED. |
Comment by Alexander Vladishev [ 2012 Feb 01 ] |
(7) include/triggers.inc.php:2317 A 'triggerArray' variable can be undefined. <pavels> RESOLVED. |
Comment by Alexander Vladishev [ 2012 Feb 01 ] |
(8) Operation "Copy selected to..." and "Full clone" copies trigger dependencies only for one level. All child triggers remains without dependencies. <pavels> RESOLVED. |
Comment by Alexander Vladishev [ 2012 Feb 01 ] |
(9) When adding trigger with dependencies, new child triggers are added without dependencies. <pavels> RESOLVED. |
Comment by Alexander Vladishev [ 2012 Feb 01 ] |
(10) Mass update operation clears all dependencies. Related issue: <pavels> This problem is not related to the current issue, I suggest we fix it in a separate branch. Shouldn't it be a blocker? Looks quite nasty. |
Comment by Alexander Vladishev [ 2012 Feb 02 ] |
Related issue: <pavels> Isn't this a server side problem? |
Comment by Alexander Vladishev [ 2012 Feb 06 ] |
Successfully tested! |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 07 ] |
Merged to 1.8 r25222. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 07 ] |
The problem persists in the trunk, but we need to close |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 09 ] |
Alexander has written a spec on how templated trigger dependencies should be handled. It's available here http://zabbix.org/wiki/Docs/specs/ZBX-4333 <zalex> I guess we have |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Feb 14 ] |
The fix for the trunk is available in /branches/dev/ RESOLVED. |
Comment by Oleksii Zagorskyi [ 2012 Feb 15 ] |
|
Comment by Eduards Samersovs (Inactive) [ 2012 Mar 01 ] |
(11) Create T2 from T3 dependence. Create T1 from T2 dependence. Create T3 from T1 dependence. The result is incorrect error message, seems update with rollback happens. <pavels> Indeed, we need to create the triggers first, and only then can we validate the dependencies and rollback, if something is not right. To fix this, we would need to completely rewrite the code. <Eduard> CLOSED |
Comment by Eduards Samersovs (Inactive) [ 2012 Mar 01 ] |
(12) Trigger can be dependent on himself. P.S. When we try remove trigger dependence on himself error message is shown: <pavels> RESOLVED. |
Comment by Eduards Samersovs (Inactive) [ 2012 Mar 01 ] |
(13) Create template with trigger (TT1). Create host with trigger (HT1). Create dependence TT1 to HT1. Save. Try remove this dependence - error message is shown.. Updated: Trigger "t1" on "dep_t1". <pavels> RESOLVED. |
Comment by Eduards Samersovs (Inactive) [ 2012 Mar 01 ] |
(14) Create Template with 1 item and 2 triggers (T1 and T2). Create trigger dependence T2 from T1. Make full clone. Error message is shown.. Created: Item "cpu t1" on "dep_t1_clone". <pavels> RESOLVED. |
Comment by Eduards Samersovs (Inactive) [ 2012 Mar 01 ] |
(15) Create Template with 1 item and 2 triggers (T1 and T2). Create trigger dependence T2 from T1. Try "copy to" T1 to some other template. Validation message is confusing.. Created: Trigger "t1.1" on "dep_t2_clone". <pavels> RESOLVED. <pavels> Sorry, I've misunderstood your description. RESOLVED. |
Comment by Eduards Samersovs (Inactive) [ 2012 Mar 01 ] |
(16) Some messages are not translatable. CTrigger->addDependencies() CTrigger->deleteDependencies() <pavels> RESOLVED. |
Comment by Eduards Samersovs (Inactive) [ 2012 Mar 07 ] |
Tested |
Comment by Oleksii Zagorskyi [ 2012 Mar 08 ] |
Pavels, just interesting, why here is so many work for trunk although we have resolved and closed <pavels> More like additional bug fixes. Even after |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 08 ] |
I've updated to the latest trunk and manually resolved some conflicts, please check that everything is ok in CTemplate.php, CTrigger.php and CTriggerGeneral.php. <Eduard> Unfortunately can't find any bug, so CLOSED |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 08 ] |
Merged to trunk r25906. CLOSED. |
Comment by Pavel Timofeev [ 2012 Mar 12 ] |
It's very very awaiting change for new 1.8 release. |