[ZBX-4365] The "failed logins attempted" text in frontends/php/include/page_header.php should use proper gettext plural forms Created: 2011 Nov 19  Updated: 2017 May 30  Resolved: 2012 Mar 20

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.9.9 (beta)
Fix Version/s: 2.0.0rc2

Type: Incident report Priority: Trivial
Reporter: Łukasz Jernaś Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: localization, trivial
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

This snippet in page_header.php:
$error_msg = array(
new CSpan($failed_attempt, 'bold'),
_(' failed login attempts logged. Last failed attempt was from '),
new CSpan($attempip, 'bold'),
_(' on '),
new CSpan(zbx_date2str(_('d.m.Y H:i'), $attempdate), 'bold'),
);
error(new CSpan($error_msg));

Should use an ngettext call so it can be properly translated into some languages, and also a rewrite to using string parameters so that the entire string would be one sentence would ease the translation a lot.



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 12 ]

(1) Another bug: if the user tries to login with a correct username, but an invalid password - he's logged in as a guest, but he should see an error message.

<zalex> Yeah, unexpected, but that's only in the trunk. 1.8 branch is ok.

<pavels> RESOLVED.

Comment by Alexey Fukalov [ 2012 Mar 13 ]

(2)
Please review my change in rev. 26029

<pavels> CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Mar 14 ]

Fixed in trunk r26052.

CLOSED.

Comment by Oleksii Zagorskyi [ 2012 Mar 19 ]

ability to "Login as Guest" from login page disappeared starting from revision 26053.
REOPENED

<pavels> RESOLVED.
<zalex> Successfully TESTED.

<Vedmak> CLOSED

<pavels> Fixed in trunk r26297.

Generated at Fri Apr 26 17:43:59 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.