(1) Don't use concatenation in messages, use the _s() function instead.
<Slava>RESOLVED r 24281
<pavels> Not sprintf() but _s(). It's our standard gettext wrapper for strings with arguments.
<Slava> RESOLVED r 24506
<pavels> CLOSED.
(2) The input parameters that we use in SQL queries should always be escaped. Use the zbx_dbstr to escape the name in get_valuemap()
<SlaVa>RESOLVED r 24281
<pavels> CLOSED.
(3) We use upperCamelCase for function names. Plus, I suggest we rename the get_valuemap function to getValuemapByName($name) and make the $name parameter obligatory.
<SlaVa>RESOLVED r 24281
<pavels> One more thing, all the tables in SQL queries must use an alias. Even if there's only one table.
<Slava> RESOLVED r 24506
<pavels> CLOSED.
(4) [GUI] Please review my changes in r24304
<Slava>CLOSED
(5) [GUI] Cannot update value map
ERROR: Cannot add value map. Map with name "Service state" already exist
<Slava>RESOLVED r 24359
<pavels> Still not working. REOPENED.
<Slava> RESOLVED r24490
<pavels> I thing you've meant
isset($_REQUEST['valuemapid']) && bccomp($_REQUEST['valuemapid'], $prevMap['valuemapid']) == 0
intead of
isset($prevMap['valuemapid']) && bccomp($_REQUEST['valuemapid'], $prevMap['valuemapid']) == 0
<Slava>Resolved r 24498
<pavels> CLOSED.
(6) it should be "already exists"
<Slava>fixed
it should be also verified whether the message should have the trailing dot or not (according to the guidelines)
<SlaVa>https://zabbix.org/wiki/Docs/specs/syntax :
2 . Main status messages like "Host added" (displayed on green/red background at the top of the page) should never end with a dot.
RESOLVED
<pavels> CLOSED.
(5) [GUI] "Cannot add or update value map" -->For this on 30.12.2011 has been created separate issue ZBX-4498
<pavels> This fix hasn't been merged yet.
<Slava> fixed in r 24515
(6) Please review my changes in r24512.
<Slava>CLOSED
TESTED.
Please close (6) before merging. Also, after updating to the latest trunk, please, fix (5).
<Slava> fixed in r 24515
(7) merge to trunk has lots of coding guideline violations and modifies several unrelated changelog entries. i would strongly suggest reverting it, reviewing all modified code for coding style and doublechecking what it does to the changelog
edit : ok, changelog probably was intentional. why wasn't it mentioned in the commit message ?
<Slava> Sorry. I must recommit this with detailed description ?
<richlv> well, this time i'd say that it would be enough to fix formatting for all modified lines - but in future, describing all changes in the commit message would be highly appreciated 
<Slava> You are so kind. RESOLVED r 24542
<richlv> 24542 has a commit message "updated to latest trunk "...
<Slava>Formating error starts after conflict resolving in 'valuemap.inc.php' . Now i re-resolve this conflicts.
<pavels> CLOSED.
<Slava> Pavel, please review my confict resolving in 24542 'valuemap.inc.php'
<pavels> CLOSED. Before merging to trunk, please review my changes in r24578 and r24579.
<Slava> CLOSED
fixed in trunk in 24575
Fix for 1.8 is TESTED.
Please review my changes before merging.
<Slava> CLOSED
fixed in 1.8 r 24593
Reopened to replace 2.0 to 1.9.9 in the Fix version/s
Closed again.