[ZBX-4790] *ERROR*s in trigger expressions in items.php Created: 2012 Mar 22  Updated: 2017 May 30  Resolved: 2012 Apr 02

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.0.0rc1
Fix Version/s: 2.0.0rc3

Type: Incident report Priority: Critical
Reporter: Alexander Vladishev Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File screenshot-1.jpg     JPEG File screenshot-2.jpg    

 Description   

See screenshots.

 Comments   
Comment by Toms (Inactive) [ 2012 Mar 23 ]

Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBX-4187

Comment by Alexander Vladishev [ 2012 Mar 23 ]

(1) Please review my changes in r26357

<Toms> RESOLVED
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Mar 23 ]

(2) Fresh "Undefined indexes":
tr_events.php: Undefined offset: 0 [include/triggers.inc.php:1935]
dashboard.php: Undefined offset: 0 [include/blocks.inc.php:314]

<Toms> RESOLVED in r26392
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Mar 23 ]

(3) Now Trigger()->get() returns hostid, functionid or itemid as key. It is correct?

<Toms> RESOLVED - changed back to previous style

<Sasha> REOPENED Why? Really it works quicker?

<?php
$string = str_repeat('1', 1024);
for ($j = 0; $j < 10000; $j++) {
for ($i = 0; isset($string[$i]); $i++) {
}
}
?>
Execution time: 0m0.524s

<?php
$string = str_repeat('1', 1024);
for ($j = 0; $j < 10000; $j++) {
for ($i = 0; $i < strlen($string); $i++) {
}
}
?>
Execution time: 0m2.188s

<Toms> RESOLVED after long debates and benchmarking.
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Apr 02 ]

(4) frontends/php/include/views/configuration.item.list.php:137 invalid hostid value in a trigger URL
triggers.php?form=update&hostid=0&triggerid=13000&sid=164662547c997f94

<Toms> RESOLVED in r26520
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Apr 02 ]

(5) frontends/php/items.php:873 'preservekeys' => true These changes are necessary?

<Toms> RESOLVED in r26520
<Sasha> CLOSED

Comment by Alexander Vladishev [ 2012 Apr 02 ]

Tested. Please review my changes in r26524.

Comment by Toms (Inactive) [ 2012 Apr 02 ]

Fixed in 2.0.0rc3 r26539

Generated at Thu Apr 25 16:51:32 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.