XML export/import in 2.0 (ZBX-4867)

[ZBX-4868] Import of maps with map elements. Created: 2012 Mar 14  Updated: 2012 Apr 11  Resolved: 2012 Mar 15

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Sub-task Priority: Major
Reporter: Alexey Fukalov Assignee: Alexey Fukalov
Resolution: Fixed Votes: 0
Labels: import
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

If we import 2 maps "map1" and "map2" where "map2" is used inside "map1", "map2" must be created first and then "map1".



 Comments   
Comment by Alexey Fukalov [ 2012 Mar 15 ]

dev branch: svn://svn.zabbix.com/branches/dev/ZBXNEXT-1149

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 20 ]

If variable will be not array error will be shown, we must check "is_array"

if (isset($map['selements']))

{ $map['selements'] = array_values($map['selements']); }

if (isset($map['links']))

{ $map['links'] = array_values($map['links']); }

<Vedmak> for now we expect that xml is correct, it's not possible that these would be strings in correct xml. Validation probably will be implemented later.
<Eduard> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 20 ]

(2) New files CImporter.php CMapImporter.php are without copyright header

<Vedmak> RESOLVED
<Eduard> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 21 ]

(3) Will be good to throw correct warning when circular map dependencies are detected. M1 depends from M2, M2 depends from M3, M3 depends from M1

<Vedmak> RESOLVED
<Eduard> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 21 ]

(4) Please redesign import form

<Vedmak> RESOLVED
<Eduard> CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Mar 21 ]

(5) Please think about changing isset to empty in this places:
if (!isset($map['selements'])) {...

if (isset($maps[$elementMapName]['selements'])) {...

<Vedmak> RESOLVED
<Eduard> CLOSED

Comment by Alexey Fukalov [ 2012 Mar 22 ]

svn://svn.zabbix.com/trunk 26328

Generated at Thu Apr 18 22:57:28 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.