[ZBX-4894] source ip detection doesn't work with fping3 Created: 2012 Apr 19  Updated: 2017 May 30  Resolved: 2016 Feb 29

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: None
Fix Version/s: 2.2.12rc1, 2.4.8rc1, 3.0.2rc1, 3.2.0alpha1

Type: Incident report Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 4
Labels: fping, icmpping
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File fping-help.txt    

 Description   

fping finally seems to be picked up by a new maintainer - which is great (see http://fping.org/ )

the problem is that zabbix source ip detection breaks with fping3.

zabbix tries to detect whether fping help output contains -I or -S flag (in that order), and uses that option with the source ip specified.

unfortunately for zabbix, fping3 uses -I for source interface, and -I comes first in the fping3 help output, so zabbix picks it up and uses -I<sourceip>, which fails and makes fping3 to ignore this parameter

this is true for both fping 3.0 and 3.1-rc1 (both already used in gentoo)



 Comments   
Comment by richlv [ 2012 Apr 19 ]

as for how to properly solve this... hard to say. zabbix must be able to detect & work properly with vanilla fping2, patched with both flags and also fping3.

maybe do 'fping -v' first, if it's >= version 3, use -S (until source interface is implemented in zabbix ), fallback to the existing detection otherwise ?

Comment by richlv [ 2012 Apr 19 ]

referenced in gentoo bug https://bugs.gentoo.org/show_bug.cgi?id=412659

Comment by Alexei Vladishev [ 2012 Apr 20 ]

I am not sure it is a bug, it sounds like a feature request (improvement).

Comment by richlv [ 2012 Apr 25 ]

...and it might get resolved in fping3, so only early fping3 versions might be affected.
upstream bug https://github.com/schweikert/fping/issues/2

Comment by Oleksii Zagorskyi [ 2012 Nov 10 ]

FreeBSD started to use v3.4 in its ports three (i.e. as stable branch) from 24 Sep 2012 09:16:00
http://www.freshports.org/net/fping/

Debian is using already v3.2 in testing repo and v3.4 in experimental repo.
They started to test 3.1~rc1 from 26 Apr 2012
http://packages.debian.org/wheezy/fping
http://packages.debian.org/experimental/fping

Comment by Matthew Marlowe [ 2013 Jan 19 ]

any update on this bug? We're still advising Gentoo Linux users to avoid using fping >= 3.0 with zabbix and have been for over 6 months..I'd like to get clarification if the problem still exists, whether it really is a problem or just a feature request, and/or what the long term solution will be....

Comment by richlv [ 2013 Jan 19 ]

there are no specific plans to support all functionality with fping3 yet. we'll probably get to that when most distributions in wide use will have migrated to it

Comment by Volker Fröhlich [ 2013 Oct 20 ]

Information for users of Fedora and EPEL:

EPEL5 and 6 only ship fping-2.4b2. This version doesn't support setting a source IP address. You've got to set up routing accordingly or mangle datagrams with iptables to manipulate the routing decision, if necessary.

All maintained Fedora releases ship fping-3.5. We're avoiding the problem of flag detection by hard-coding the flag to -S.

Comment by Volker Fröhlich [ 2014 Feb 16 ]

EPEL 7 will have fping 3.5 and the behavior thus will be the same as in Fedora.

Comment by Vincent Andries [ 2015 Apr 12 ]

This seems to also affect Zabbix 2.4.4 release on Debian Wheezy. Debian uses fping version 3.2.

The patch on http://pkgs.fedoraproject.org/cgit/zabbix.git/tree/zabbix-1.8.12-fping3.patch still seems to fix this.
Kind of strange that a 3 year old bug is still unresolved...

Comment by Aleksandrs Saveljevs [ 2016 Feb 23 ]

Attached "fping-help.txt" demonstrates help output for fping tags that are not release candidates (based on https://github.com/schweikert/fping).

Comment by Aleksandrs Saveljevs [ 2016 Feb 23 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-4894 by preferring "-S" option over "-I" option if both are present.

Comment by Andris Mednis [ 2016 Feb 24 ]

Successfully tested.

Comment by Aleksandrs Saveljevs [ 2016 Feb 29 ]

Fixed in pre-2.2.12rc1 r58772, pre-2.4.8rc1 r58773, pre-3.0.2rc1 r58774, pre-3.1.0 (trunk) r58775.

Generated at Fri Apr 26 01:03:20 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.