[ZBX-5257] navigation bar shows incorrect host/template if trigger properties accessed from context menu Created: 2012 Jun 29  Updated: 2017 May 30  Resolved: 2012 Aug 01

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: None
Fix Version/s: 2.0.3rc1, 2.1.0

Type: Incident report Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: triggers
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

have a trigger in problem state. go to config hosts or templates, click on "triggers" for a different host or template.
go to monitoring -> triggers, click on trigger name, click on "Configuration of triggers"

observe the navigation bar happily showing the previous host/template that we edited triggers for

mighty confusing



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 09 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-5257.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 10 ]

(1) Same problem with the links to parent templated triggers and trigger prototypes in the configuration forms.

<pavels> RESOLVED.

<Toms> CLOSED. see (3)

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 11 ]

(2) A couple of related bugs. If we open an inherited graph prototype, follow the link to the parent prototype and save it, we'll be redirected to an empty list. If we do the same with a trigger prototype, we are redirected to a list of trigger prototypes from the original trigger prototypes, not the prototypes from the parent template.

<pavels> RESOLVED.

<Toms> CLOSED. see (3)

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 11 ]

It turned out, that there are numerous problems with those links in the frontend.

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-5257.

Comment by Toms (Inactive) [ 2012 Jul 12 ]

(3) It is not the best way to pass all ids through URL if they can be retrieved from single id. If trigger id is given it is possible to retrieve hostid from DB.

<richlv> what about triggers that reference multiple hosts ? not sure whether it applies in this case, just curious

<Toms> I think that you can take first or one which are in some way more important in a way in I am not aware of.

<pavels> This will work for items and LLD rules, but will not do for triggers and graphs, because we can navigate to these items from different hosts. I such cases, the navigation form should display the host we came from, not the first one.

<Toms> You can pass id as extra variable when necessary, but if it not set you need to retrieve it from DB.

<Vedmak> CLOSED

Comment by Toms (Inactive) [ 2012 Jul 12 ]

(4) CPageFilter shouldn't be used in getTriggerFormData() in forms.inc.php

<pavels> RESOLVED.

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Jul 16 ]

(5)
When we select All/All and open some trigger for edit, host bar is not shown. Should be checked for graphs and prototypes too.

<pavels> Same thing for applications.

<pavels> RESOLVED.

<Vedmak> Go to Applications, select All/All, open existing application, host info is missing.

<pavels> It seems to have been broken by your changes in r28971.

  • $data['hostid'] = get_request('hostid') ? get_request('hostid') : $data['apphostid'];
    + $data['hostid'] = get_request('hostid', $data['apphostid']);

It is not equivalent, because hostid can also be 0. It this case we should also use the hostid from the application data.

<Vedmak> huh, ok, sorry for that CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Jul 31 ]

Fixed in 2.0.3rc1 r29241 and 2.1.0 r29242.

CLOSED.

Comment by Alexander Vladishev [ 2012 Aug 01 ]

(6) empty form on editing trigger prototypes

<pavels> RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-5257.

<Toms> CLOSED

Comment by Toms (Inactive) [ 2012 Aug 03 ]

TESTED

Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 03 ]

Fixed in 2.0.3rc1 r29396 and 2.1.0 r29397.

CLOSED.

Generated at Sat Apr 20 10:58:28 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.