[ZBX-5440] Cannot remove last user from user group in user group setting screen Created: 2012 Aug 13 Updated: 2017 May 30 Resolved: 2012 Aug 21 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | 2.0.3rc1 |
Fix Version/s: | 2.0.3rc1, 2.1.0 |
Type: | Incident report | Priority: | Minor |
Reporter: | Kodai Terashima | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | frontend | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
Description |
Cannot remove last user from user group in user group setting screen. 1. create user group G user U can remove from group G in user's setting screen |
Comments |
Comment by Toms (Inactive) [ 2012 Aug 16 ] |
Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBX-5440 |
Comment by Toms (Inactive) [ 2012 Aug 16 ] |
Fixed as well inability to remove last right from permissions and done refactoring of user group update and massupdate methods. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 16 ] |
(1) I have a group with a single group under the "deny all" permission. When I try to remove it, i get the following error: Undefined variable: rightidsToUnlink [api/classes/CUserGroup.php:655] May be this can just be fixed by replacing the whole right insert/update/delete block with DB::replace(). <Toms> RESOLVED in r29641 <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 16 ] |
(2) 1. I suggest we change the "User cannot be added to a disabled group or group with disabled GUI access by himself." message to "User cannot add himself to a disabled group or a group with disabled GUI access." <martins-v>My version would be "Users cannot add themselves to a disabled group or a group with disabled GUI access". 2. When the update methods lack the ids parameter we usually write "Incorrect arguments passed to function." instead of "No user group ids provided." 3. We write "User group "%s" already exists." instead of "User group with name "%s" already exists." <Toms> RESOLVED in r29641 <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 16 ] |
(3) Please review some minor corrections in r29607. <Toms> RESOLVED in r29641 <pavels> CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Aug 20 ] |
TESTED. |
Comment by Toms (Inactive) [ 2012 Aug 20 ] |
Resolved in 2.0.3rc1 r29647 and 2.1.0 r29648 |
Comment by richlv [ 2012 Aug 20 ] |
i suspect the last comment and "Fix Version/s" might be wrong <Toms> RESOLVED. Why there is 4th version available in JIRA? <richlv> 2.0.3 got delayed a bit more than expected - and why not ? |