[ZBX-5444] Hosts in maintenance not highlighed in Last 20 issues Created: 2012 Aug 14  Updated: 2017 May 30  Resolved: 2012 Oct 02

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.0.3rc1, 2.1.0
Fix Version/s: 2.0.3rc2, 2.1.0

Type: Incident report Priority: Minor
Reporter: Alexey Pustovalov Assignee: Martins Valkovskis
Resolution: Fixed Votes: 0
Labels: maintenance, regression, usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File 5444.jpg    

 Description   

After ZBXNEXT-1066 has been implemented, hosts in maintenance had not highlighted in orange color.

This is a regression.



 Comments   
Comment by Toms (Inactive) [ 2012 Aug 16 ]

Please be more specific.
Where maintenance has "Last 20 issues"?

Comment by Alexey Pustovalov [ 2012 Aug 16 ]

"Last 20 issues" widget column "Host". Host names highlighted orange before ZBXNEXT-1066.

Comment by Alexey Pustovalov [ 2012 Aug 16 ]

Toms, you can see our manual http://www.zabbix.com/documentation/2.0/manual/maintenance last paragraph:

Hosts in maintenance are displayed accordingly in:

in Monitoring → Dashboard - the names of hosts in maintenance are displayed in orange (unless you have unset the display of hosts in maintenance with the dashboard filtering function)

Comment by Toms (Inactive) [ 2012 Aug 16 ]

OK, now I see the problem. I assumed there is talk about orange theme.

But then arises the question, what should we do in orange theme?

Comment by Alexey Pustovalov [ 2012 Aug 16 ]

Toms, please check Monitoring->Triggers page. There is triggers should be orange too.

Comment by Toms (Inactive) [ 2012 Aug 17 ]

Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBX-5444

Comment by richlv [ 2012 Aug 17 ]

(1) please, describe in detail all the changes, done in this dev branch

<Toms> As there where problems with orange color in dark orange theme, we decided to introduce icon for hosts in maintenance.
For those hosts in maintenance we show icon with wrench alongside.
Now it is possible to click on the icon and see maintenance name, type and description.

<Vedmak> CLOSED

Comment by richlv [ 2012 Aug 17 ]

(2) trailing newline seems to be missing for default.css

<Toms> RESOLVED in r29797

<Vedmak> CLOSED

Comment by richlv [ 2012 Aug 17 ]

(3) there's some commented out code left (//$columnLeft->setAttribute('width', '10'); etc)

<Toms> RESOLVED in r29797

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Aug 21 ]

(4)
Icons are not shown.

<Toms> RESOLVED in r29797

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Aug 21 ]

(5)
In Monitoring->Triggers icon has popup opened on click, but in Dashboard it does not.

<Toms> RESOLVED in r29797

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Aug 21 ]

(6)
In trunk in Monitoring ->Triggers maintenance description is shown in popup, in dev. branch it's not.

<Toms> RESOLVED in r29797

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Aug 21 ]

(7)
I think css classes for icons should begin with "icon-".

<Toms> Please write coding guideline for naming icons.

<Toms> Decided to leave as it is.

<Vedmak> icon class should be renamed, but css can be left in default.css

<Toms> RESOLVED in r29827

<Vedmak> CLOSED

Comment by Alexey Fukalov [ 2012 Aug 24 ]

(8)
If user doesn't have permissions on maintenance, only icon should be shown without hint.

<Toms> RESOLVED in r29827

<Vedmak> CLOSED

Comment by Toms (Inactive) [ 2012 Aug 27 ]

Fixed in 2.0.3rc1 r29853 and 2.1.0 r29855

Comment by richlv [ 2012 Sep 11 ]

(9) now http://www.zabbix.com/documentation/2.0/manual/maintenance#display is wrong. it should describe how it was before and how it is now.
http://www.zabbix.com/documentation/2.0/manual/introduction/whatsnew203#maintenance_indicated_by_an_icon might help with that

<martins-v>RESOLVED. http://www.zabbix.com/documentation/2.0/manual/maintenance#display now has a description of how it is now and how it was before

<richlv> seems to ok to me - thanks, CLOSED

Comment by richlv [ 2012 Oct 09 ]

this resulted in regression : ZBX-5679

Generated at Sat Apr 20 09:36:50 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.