It looks similar to ZBX-5049

<Eduard> RESOLVED

Removed docs for these methods.

<Eduard> RESOLVED

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-5489

(1) Should CEvent deleteByTriggerIDs() function be removed?

<Eduard> We remove delete methods, why deleteByTriggerIDs must stay? Especially that it isn't used where in a code.

<Toms> CLOSED. It was just for clarification. Hope that no one relays on undocumented functions.

(2) Missing newlines at the end of changed files.

<Eduard> Can't repeat.

<Toms> CLOSED. Seems like subversion doesn't show last newline.

(3) @param string $triggerids should be @param int|array $triggerids

<Eduard> RESOLVED

<Toms> CLOSED

(4) function addEvent() in triggers.inc.php should be carefully refactored:

a) zbx_objectValues($events, 'objectid') same as $triggerids;

b) unnecessary check if ($event['object'] != EVENT_OBJECT_TRIGGER). because 'object' => EVENT_OBJECT_TRIGGER;

c) $eventDbFields unused;

d) can't call self::exception() in this scope;

e) getting eventid and storing in DB should be done in transaction + eventid could be just incremented on next inserts

f) looping through triggers and events can be done in a single loop

I think there could be more as well.

<Eduard> RESOLVED, good testing!

<Toms> CLOSED. done some refactoring

(5) only TRIGGER_VALUE_UNKNOWN events can be created by frontend, this should be forced within function and commented as well, so there would be no possibility to call addEvent() with different tyope of events.
Function should be renamed addUnknownEvent() or something like that.

<Eduard> RESOLVED, Good advice!

<Toms> CLOSED

(6)
$hostids should be written as $hostIds, every word starts with a capital letter in variable naming, except first one

<Eduard> Decided with Aleksey and Sasha to launch new exception for variables names witch ends with "id" or "ids" write with lowercase first letter, because otherwise we needs rename all frontend with API..

<richlv> then that must be documented at https://zabbix.org/wiki/Docs/specs/coding_style#Naming_conventions

<Eduard> Done.

<richlv> is that only when it ends with "id[s]" ? what if it's something like "matchTriggerIdToSomethingElse" ?

<Eduard> Mainly it's exception only for variables like $triggerids where "ids" at the end of a name, all others events must be like "matchTriggerIdToSomethingElse"

<richlv> ok, i really don't like it, because it's terribly convoluted and inconsistent, but i clarified that point a bit - please, review

<Toms> CLOSED. But don't like inconsistency

Review my changes up to r29864

<Eduard> CLOSED, Great job!

TESTED

Fixed in versions pre-2.1.0 (beta) r29884, pre-2.0.3 r29882