[ZBX-5579] Web-interface displays "Acknowledged" even if a trigger has no events Created: 2012 Sep 12  Updated: 2017 May 30  Resolved: 2012 Oct 23

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.0.3, 2.1.0
Fix Version/s: 2.0.4rc1, 2.1.0

Type: Incident report Priority: Minor
Reporter: Alexey Pustovalov Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: acknowledges, events, triggers
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File acknowledged-triggers.jpg     PNG File tr_status.png    
Issue Links:
Duplicate
duplicates ZBX-3949 Triggers stuck as "acknowledged" afte... Closed

 Description   

Web-interface calculates a number of acknowledged events on the tr_status.php and if events do not exist at all web-interface display "Acknowledged" anyway.



 Comments   
Comment by Alexey Pustovalov [ 2012 Sep 12 ]

The problem here:

                        if($trigger['event_count']){
                                $to_ack = new CCol(array(new CLink(_('Acknowledge'), 'acknow.php?triggers[]='.$trigger['triggerid'].'&backurl='.$page['file'], 'on'), ' ('.$trigger['event_count'].')'));
                        }
                        else{
                                $to_ack = new CCol(_('Acknowledged'), 'off');
                        }

We think all events already acknowledged if $trigger['event_count'] non-exist or equal 0. But if a trigger has not any events we can not say what they has been acknowledged!

Comment by richlv [ 2012 Sep 12 ]

but if there are no events, what should we display then ?

Comment by Alexey Pustovalov [ 2012 Sep 12 ]

old fired triggers can be without events (small keep time of events for records or partitioning).

Comment by Alexey Fukalov [ 2012 Sep 17 ]

We decided to show 'No events' string for such triggers.

Comment by Alexey Fukalov [ 2012 Sep 17 ]

dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5579

Comment by Pavels Jelisejevs (Inactive) [ 2012 Sep 18 ]

(1) If I select a host without triggers on the trigger status page, I receive an error:

Undefined variable: triggerIdsWithoutUnackEvents [tr_status.php:400]

Vedmak RESOLVED

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Sep 18 ]

(2) Can you please change 'noEvents' to 'hasEvents'. I, personally, think it's more intuitive that way.

Vedmak RESOLVED

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2012 Sep 19 ]

TESTED.

Comment by Alexey Fukalov [ 2012 Oct 04 ]

Fixed in 2.0.4rc1 r30536, pre-2.1.0 r30537.

Comment by Alexander Vladishev [ 2012 Oct 19 ]

(3) Triggers in an "Acknowledged" status if trigger has only unknown or not significant events. We can't acknowledge these events.

https://support.zabbix.com/secure/attachment/20492/acknowledged-triggers.jpg

Comment by Alexey Fukalov [ 2012 Oct 19 ]

Dev branch: svn://svn.zabbix.com/branches/dev/ZBX-5579

Comment by Alexey Pustovalov [ 2012 Oct 20 ]

(4) That change should be documented on http://www.zabbix.com/documentation/2.0/manual/web_interface/frontend_sections/monitoring/triggers

<richlv> mentioned in http://www.zabbix.com/documentation/2.0/manual/introduction/whatsnew204
trigger section part still missing

martins-v Documented in
http://www.zabbix.com/documentation/2.0/manual/web_interface/frontend_sections/monitoring/triggers
http://www.zabbix.com/documentation/2.2/manual/web_interface/frontend_sections/monitoring/triggers

alexei CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Oct 22 ]

(5) Error if filter events by "Show unknown events":
Undefined index: 10087 [events.php:671]
Undefined index: [events.php:720]
Argument 1 passed to hostMenuData() must be an array, null given, called in /home/zabbix/www/testing-ZBX-5579/frontends/php/events.php on line 721 and defined [include/hosts.inc.php:1312]

Vedmak seems it caused by event from templated trigger
Eduards CLOSED, seems my database is corrupted

Comment by Eduards Samersovs (Inactive) [ 2012 Oct 22 ]

(6) Please pass $_REQUEST['showUnknown'] directly as option to Event API

Vedmak left as it is, as discussed.
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2012 Oct 23 ]

Tested!

Comment by Alexey Fukalov [ 2012 Oct 23 ]

Fixed in 2.0.4rc1 r31036, pre-2.1.0 r31037.

Generated at Fri Apr 19 18:52:30 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.