RESOLVED IN svn://svn.zabbix.com/branches/dev/ZBX-5639 r31105

(1) Mode: By trigger template
Select some group and host with triggers
Triggers doesn't appear in list, thou they should.

oleg.egorov RESOLVED

tomtom this problem still exists

choose template group, then template, then host, now change template. You will see empty list, but host selection is to "all". If you chose some host and then again "all" you will see triggers.

oleg.egorov I can't reproduce this issue now, if this problem exist, please say me

oleg.egorov RESOLVED

tomtom Revision number missing!
This is quite hackish leading to following bug:
mode:"By trigger template"
open availability report in two tabs
in first filter some triggers using first 3 drop-downs
in second tab do the same with diferent template
in first tab press filter, selected options are gone

as well there is undefined index:
Undefined index: filter_hostid [report2.php:80]
it is noticeable in several combinations, including with mode: "By host"

oleg.egorov RESOLVED IN r31322 + minor minor code refactoring in r31323

tomtom CLOSED

(2)
if (a) {
if (b)

}
else

oleg.egorov RESOLVED

tomtom Changes regarding those "ifs" changed logic and still wasn't optimal. See r31155, if OK close this sub-issue.

oleg.egorov CLOSED

oleg.egorov After changes in r31155, select in form "By trigger template" works incorrect

oleg.egorov Fixed in r31204

tomtom CLOSED. This worked incorrect as well in code from which I made changes

(3)
select_config() should be assigned to variable $config not $gui, as it is everywhere in the code. As well $gui stands for Graphical User Interface and would be misleading anyway. Current variable $config should be renamed to something like $availabilityReportMode.

oleg.egorov RESOLVED

tomtom CLOSED

(4) select_config() should be called right before usage of its returned data.

oleg.egorov RESOLVED

tomtom CLOSED

(5) as an addition to this issue it would be nice to fix that selected values would be remembered in filter if "remember selected" is selected in configuration.

oleg.egorov In form "By trigger template" not need remember "Template trigger" and "Filter by host group" - Pavel decision

RESOLVED in r31144

Mode is not remembered now.

Group and template/host is only remembered if button "filter" is clicked.

Group and template/host is remembered if checkbox "Remember selected" in Configuration is checked.

oleg.egorov RESOLVED

tomtom CLOSED

(6) $_REQUEST['config'] as well should be renamed according to its logic.

oleg.egorov RESOLVED

tomtom CLOSED

(7)

if (!isset($_REQUEST['config']))

instead of 0, constant AVAILABILITY_REPORT_BY_HOST should be used

oleg.egorov RESOLVED

tomtom CLOSED

I found problem in 2.0.4, don't work "Filter by host group"
It will be fixed under this ZBX

oleg.egorov RESOLVED r31297

tomtom CLOSED

TESTED

Review my changes in r31462, if OK merge.

oleg.egorov CLOSED

RESOLVED IN 2.0.4 r31471, 2.1.0 r31472
CLOSED