[ZBX-5684] inconsistency in returned resource types regarding LLD (rule, prototype, created object). no checks for allowed types for some methods. Created: 2012 Oct 10 Updated: 2017 May 30 Resolved: 2012 Nov 29 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | API (A) |
Affects Version/s: | 2.0.3 |
Fix Version/s: | 2.0.4rc1, 2.1.0 |
Type: | Incident report | Priority: | Critical |
Reporter: | Oleksii Zagorskyi | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | api, lld, prototype | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified | ||
Environment: |
trunk rev 30757 (~2.0.3 release) |
Issue Links: |
|
Description |
(1)
We have also DiscoveryRule, ItemPrototype, TriggerPrototype and GraphPrototype API classes, they all work correctly and return only appropriate types (I've just tested). So to be consistent we have to limit the "item.get" method to return only "real" items, i.e. 0 and 4 types only. Then in documentation: (2) "trigger.update" and "graph.update" are ok in this regard and don't allow such incorrect action - "No permissions to referred object or it does not exist!" Please consider which particular tests I could forget and skip. |
Comments |
Comment by Alexei Vladishev [ 2012 Oct 10 ] |
Again, it is all about API validation. It should be part of a single issue, we already have one registered. zalex_ua ohh, I just started from another issue and probably ended up with this new report because I forgot about the registered ZBX for validation. Ok, I've added a comment there in ZBX-3783 about this issue. alexei well, if we keep reporting multiple bugs per ticket it will never be fixed. hard to read and track any progress. please stick to one ticket one bug report rule. |
Comment by Toms (Inactive) [ 2012 Nov 13 ] |
Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBX-5684 |
Comment by Eduards Samersovs (Inactive) [ 2012 Nov 22 ] |
(1) Typo in popup_trexpr.php:553 |
Comment by Eduards Samersovs (Inactive) [ 2012 Nov 22 ] |
P.S. see also ZBXNEXT-1525 |
Comment by Eduards Samersovs (Inactive) [ 2012 Nov 23 ] |
(2) "ERROR: No permissions to referred object or it does not exist!" in item prototype configuration edit page when pressing on template link. |
Comment by Eduards Samersovs (Inactive) [ 2012 Nov 23 ] |
(3) Error in Item popup: Resolved in tomtom CLOSED |
Comment by Eduards Samersovs (Inactive) [ 2012 Nov 27 ] |
Tested! |
Comment by Toms (Inactive) [ 2012 Nov 28 ] |
Fixed in 2.0.4rc1 r31754, 2.1.0 r31760 |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Nov 28 ] |
(4) Please note this in the API changelog. tomtom RESOLVED jelisejev CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Nov 29 ] |
(5) The itemprototype.get methods doesn't need a webitems parameter: item prototypes are not related to web items at all. tomtom Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBX-5684-tr for trunk jelisejev CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Nov 29 ] |
(6) API_OUTPUT_SHORTEN is used in CItemPrototype::get(). It is no longer supported in the trunk and must be removed. It should remain in 2.0 though. tomtom Fixed in dev. branch: svn://svn.zabbix.com/branches/dev/ZBX-5684-tr jelisejev CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2012 Nov 29 ] |
TESTED. |
Comment by Toms (Inactive) [ 2012 Nov 30 ] |
Fixed in 2.1.0 r31800, 2.0.4rc1 r32149 |