[ZBX-5721] Wrong action condition calculation Created: 2012 Oct 22  Updated: 2017 May 30  Resolved: 2012 Oct 25

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 1.8.15, 2.0.3
Fix Version/s: None

Type: Incident report Priority: Critical
Reporter: Pavel Timofeev Assignee: Unassigned
Resolution: Won't fix Votes: 0
Labels: actions, frontend
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Zabbix 1.8.13


Attachments: PNG File zabbix-bug.PNG     PNG File zabbix-bug2.PNG    
Issue Links:
Duplicate
duplicates ZBXNEXT-1133 Improve flexibility for action condit... Closed

 Description   

Just look at attached image.
I don't know how to explain it in english, but I'll try

When some of conditions are "not" they have to use AND instead of OR to communicate with same type conditions.

I've found this bug on Zabbix 1.8.13. I checked it on Zabbix 2.0.3 too - same result.



 Comments   
Comment by Pavel Timofeev [ 2012 Oct 22 ]

Of course, it's all about case when "Type of calculation" is automatic, i.e. "AND/OR"

Comment by richlv [ 2012 Oct 22 ]

when fixing, it should be checked what the server does in this case

Comment by Alexander Vladishev [ 2012 Oct 23 ]

It works according to documentation.

http://www.zabbix.com/documentation/2.0/manual/config/notifications/action/conditions?s[]=action&s[]=conditions#configuration

Related issue: ZBXNEXT-1133

Comment by Alexander Vladishev [ 2012 Oct 23 ]

I'm closing it as duplicate.

Comment by Pavel Timofeev [ 2012 Oct 24 ]

Hmm, ZBXNEXT-1133 was redeveloped as feqture request as I can understand.
But this problem is not feature request.
I suppose it's a bug. Calculation is wrong. Right? No? Don't you think so?
So where is new feature?
Where is common sense?

Comment by Pavel Timofeev [ 2012 Oct 24 ]

Here is second similar problem at zabbix-bug2.png.
"Host" and "Host group" condition types must communicate between them as same type.

Comment by Pavel Timofeev [ 2012 Oct 25 ]

After some thinking and seeing php code:
When "Type of calculation" set to "AND/OR" i.e auto, at calculation step on action web page it should:
1. If condition set to "NOT" ("<>" or "not like") it should be factored out as different condition type.
2. "Host" and "Host group" condition types must be considered as same condition type. For example, that types could be included in one round bracket.

I've swaped this rules because I saw such order in php code (actionconf.php, lines number 580-583).

P.S. I'm sorry for such bad and impolite English, I just don't know how to explain some quite difficult and technical things in English.

Comment by Pavel Timofeev [ 2012 Oct 25 ]

Ok, I think it's enough difficult and needs much new code in server and frontend.
I'm closing it. Big sorry for that noise.

Just some small stupid ideas:
to solve problem №1: if condition operator is "<>" or "not like" you could introduce new condition type which can't be united under brackets with any condition types (including itself).
To solve problem with host and hostgroup condition types maybe you could make some exception in calculation logic to unite it under one bracket.

Comment by richlv [ 2012 Oct 25 ]

ZBXNEXT-1133 would probably be the proper solution and offer the most flexibility

Generated at Fri Apr 26 05:48:15 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.