[ZBX-6054] CScreenBuilder requires editable permissions for SCREEN_MODE_PREVIEW Created: 2013 Jan 03 Updated: 2017 May 30 Resolved: 2013 Jan 04 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Frontend (F) |
| Affects Version/s: | 2.0.5rc1, 2.1.0 |
| Fix Version/s: | 2.0.5rc1, 2.1.0 |
| Type: | Incident report | Priority: | Blocker |
| Reporter: | Alexey Pustovalov | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | regression, screens | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
It is "regression" after View monitoring.screen sets mode SCREEN_MODE_PREVIEW, but CScreenBuilder recognizes this property as editable mode. Steps for reproduce: Look comments for a patch. |
| Comments |
| Comment by Alexey Pustovalov [ 2013 Jan 03 ] |
|
Request for screen details on Monitoring->Screens page: 3. screen->get [CScreenBuilder.php:136]
Parameters:
Array
(
[screenids] => 1853
[output] => extend
[selectScreenItems] => extend
[editable] => 1
)
Index: include/classes/screens/CScreenBuilder.php
===================================================================
--- include/classes/screens/CScreenBuilder.php (revision 32387)
+++ include/classes/screens/CScreenBuilder.php (working copy)
@@ -130,7 +130,7 @@
'output' => API_OUTPUT_EXTEND,
'selectScreenItems' => API_OUTPUT_EXTEND
);
- if (in_array($this->mode, array(SCREEN_MODE_PREVIEW, SCREEN_MODE_EDIT))) {
+ if (in_array($this->mode, array(SCREEN_MODE_EDIT))) {
$params['editable'] = true;
}
$this->screen = API::Screen()->get($params);
I'm not quite sure that the patch is fully correct. |
| Comment by Pavels Jelisejevs (Inactive) [ 2013 Jan 04 ] |
|
RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6054. Alexey, thanks for the patch =) |
| Comment by Eduards Samersovs (Inactive) [ 2013 Jan 07 ] |
|
Tested |
| Comment by Pavels Jelisejevs (Inactive) [ 2013 Jan 08 ] |
|
Fixed in 2.0.5rc1 r32522 and 2.1.0 r32521. CLOSED. |
