Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-6613

(1) Coding style
Lines in triggers.inc.php:1017 and in CTriggerPrototype.php:524 is too long

Unnecessary tabs in triggers.inc.php:1028, CTriggerPrototype.php:524 and in CTriggerPrototype.php:629

Eduards RESOLVED r.35810

oleg.egorov CLOSED

(2) Unnecesary code in triggers.inc.php:1005

$triggerFunctionValidator = new CTriggerFunctionValidator();

Defined, but not used...

Eduards RESOLVED r.35810

oleg.egorov CLOSED

(3) Please fix same problem when updating a trigger prototype

Eduards RESOLVED r.35810

oleg.egorov CLOSED

(4)
Incorrect item key "agent.ping" provided for trigger expression on "DONTEXIST". [trigger_prototypes.php:161 → CAPIObject->update() → CAPIObject->__call() → czbxrpc::call() → czbxrpc::callAPI() → call_user_func() → CTriggerPrototype->update() → getExpressionItems() in C:\xampp\htdocs\ZBX-6613\frontends\php\api\classes\CTriggerPrototype.php:614]

Host "DONTEXIST" - don't exist

Incorrect message after trigger prototype updating

Eduards RESOLVED r.35817

oleg.egorov CLOSED

(5) Function "getExpressionItems" SELECT inside foreach loop... should be discussed

Eduards Discussed and decided not to do.

oleg.egorov CLOSED

TESTED

Fixed in versions pre-2.1.0 (beta) r.35820

(6) In CTriggerPrototype line 500 you've changed array_key_exists to isset. This is incorrect, because a create request with templateid=>null must also raise an error.

Eduards RESOLVED r.35861

jelisejev CLOSED.

(7) In triggers.inc.php getExpressionItems() line

if (!isset($processedItems[$expression['host'].$expression['item']])) {

Don't use concatenated keys for such checks as there might be two different host-item pairs that produce the same concatenated strings. Then the function will work incorrectly. Use a 2D array instead.

Eduards RESOLVED r.35861

jelisejev CLOSED.

(8) In CTriggerPrototype line 534: there's no need to fetch $createdTriggers.

Eduards RESOLVED r.35861

jelisejev CLOSED.

(9) The following request fails with an error: Incorrect trigger expression.

{
    "jsonrpc": "2.0",
    "method": "triggerprototype.update",
    "params": {
        "triggerid": 13611,
        "status": 0
    },
    "id": 3,
    "auth": "7ad89cb5537b8d4127d1c283097528db"
}

Eduards RESOLVED r.35861

jelisejev CLOSED.

(10) In CTriggerPrototype::create() the expression is parsed twice. Once in the create() method, and a second time in getExpressionItems().

Eduards RESOLVED r.35861

jelisejev It would be better to pass not the separate expressions, but the whole CTriggerExpression object to getExpressionItems(). That way the parameter will be clearer.

Eduards RESOLVED r.35877

jelisejev Please review my changes in r35902.

(11) The getExpressionItems() function shouldn't throw the "Incorrect trigger expression part "%1$s".". This is done in the implode_exp() function.

Eduards RESOLVED r.35861

jelisejev CLOSED.

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-6613

Please review my changes in (10). Otherwise TESTED.

Fixed in versions pre-2.1.0 (beta) r.35905

failing tests on POSTGRESQL
error message appears when saving hosts

selecting host in configuration of hosts, click 'save'
error message appears

pg_query(): Query failed: ERROR: column "i.hostid" must appear in the GROUP BY clause or be used in an aggregate function [hosts.php:470 → CAPIObject->update() → CAPIObject->__call() → czbxrpc::call() → czbxrpc::callAPI() → call_user_func() → CHost->update() → CHost->massUpdate() → CHost->massAdd() → CHostGeneral->massAdd() → CHostGeneral->link() → DBselect() → pg_query() in /home/hudson/public_html/trunk-FRONTEND-POSTGRESQL/frontends/php/include/db.inc.php:441]

Error in query [SELECT i.key_,i.hostid FROM items i WHERE i.hostid IN ('10047','10001','10001','10047') GROUP BY i.key_ HAVING COUNT(i.itemid)>1] [ERROR: column "i.hostid" must appear in the GROUP BY clause or be used in an aggregate function]

Eduards RESOLVED r.36052

oleg.egorov CLOSED

TESTED

Fixed in versions pre-2.1.0 (beta) r.36056