[ZBX-6683] A lot of locks for strpool while gettings info this cache Created: 2013 Jun 10  Updated: 2017 May 30  Resolved: 2013 Jun 10

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: 2.0.7rc1, 2.1.0
Fix Version/s: 2.0.7rc1, 2.1.0

Type: Incident report Priority: Major
Reporter: Alexey Pustovalov Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: performance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate

 Description   

In each function from strpool.c we lock cache before any actions. It is not required, because cache is locked already before actions with strpool

 Comments   
Comment by Alexander Vladishev [ 2013 Jun 10 ]

Available in the development branch svn://svn.zabbix.com/branches/dev/ZBX-6683.

The fix affects first configuration cache update or if we have large configuration changes.

Test results (10004 hosts; 469672 items; 180841 triggers):

Cache lock time Before After Delta, %
Average (10 measurements) 6.40s 5.22s 18.45%
Minimal 6.31s 5.17s 18.07%
Comment by Andris Zeila [ 2013 Jun 18 ]

Successfully tested

Comment by Alexey Pustovalov [ 2013 Jun 28 ]

(1) whatsnew because for some users it is a great improvement.

Another test:
-with the patch:
29558:20130628:015544.152 Syncing ...
29558:20130628:015619.653 configuration syncer spent 35.501576 second while processing configuration data
3684:20130628:030949.693 Syncing ...
3684:20130628:031026.483 configuration syncer spent 36.789700 second while processing configuration data

-without the patch:
27506:20130628:021006.118 Syncing ...
27506:20130628:030501.234 configuration syncer spent 3295.115112 second while processing configuration data

sasha updated documentation:

martins-v Reviewed, with minor improvements. CLOSED.

Comment by Alexander Vladishev [ 2013 Jul 01 ]

Available in versions pre-2.0.7 r36617 and pre-2.1.0 (trunk) r36618.

Comment by richlv [ 2013 Jul 01 ]

as per dotneft's comment (1), reopening

Generated at Tue Apr 23 20:56:01 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.