[ZBX-6689] Unused code in getItemFormData() Created: 2013 Jun 11  Updated: 2017 May 30  Resolved: 2013 Jun 17

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.1.0
Fix Version/s: 2.1.0

Type: Incident report Priority: Minor
Reporter: Pavels Jelisejevs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: codequality, frontend, itemconfigform
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

In forms.inc.php:1210 in the getItemFormData() function there's a block of code, that returns the available host groups. They don't seem to be used anywhere after.

// host groups
$data['hostGroups'] = API::HostGroup()->get(array(
'editable' => true,
'output' => API_OUTPUT_EXTEND
));
order_result($data['hostGroups'], 'name');

This code should be removed.

 Comments   
Comment by Ivo Kurzemnieks [ 2013 Jun 17 ]

Checked and seems like it was unused.

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6689

Comment by Pavels Jelisejevs (Inactive) [ 2013 Jun 17 ]

TESTED.

Comment by Ivo Kurzemnieks [ 2013 Jun 17 ]

Fixed in pre-2.0.1 (trunk) r36412

Generated at Thu Apr 25 19:18:00 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.