Removed also validate_group_with_host()

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-6693

(1) Regarding _initHosts() in class.cpagefilter.php

• $defaultOptions is more appropriate than $optionsDefault;
• it is not OK to mix API call options with page filter option, this applies to $options['only_templates'];
• it is better to perform "isset($options['only_templates'])" only once and use classical "if" statement;

Eduards RESOLVED r.36361

P.S. Decided not to use pageFilter in inventories report filter so all changes in pageFilter is reverted.

tomtom CLOSED

(2) Monitoring > Screens group and hosts filters works incorrectly when dynamic items present in screen. For example, we have screen with dynamic simple graph, we should see only those groups and hosts in which there is item for simple graph. After fix we see all groups and hosts.

Eduards RESOLVED r.36369

tomtom CLOSED

(3) For host dropdown first item should be "Default" instead of "All". Applies both screens and slides.

Eduards RESOLVED r.36369

tomtom REOPENED Not fixed.

Eduards RESOLVED r.36537. Sorry I incorrectly reverted the changes in pageFilter.

tomtom CLOSED

(4)

  $tmp = $_REQUEST['filter_timesince'];
  $_REQUEST['filter_timesince'] = $_REQUEST['filter_timetill'];
  $_REQUEST['filter_timetill'] = $tmp;

change to

  $_REQUEST['filter_timesince'] = $_REQUEST['filter_timetill'];
  $_REQUEST['filter_timetill'] = $_REQUEST['filter_timesince'];

This is wrong.

Eduards RESOLVED r.36361

tomtom REOPENED

If we change this then zbx_swap() should be used;

Eduards RESOLVED r.36537

tomtom CLOSED

(5) report2.php line:180

$hosts = API::Host()->get(array(
  'templateids' => $_REQUEST['hostid']
));

this was fitting in one line

Eduards RESOLVED r.36361

tomtom CLOSED

(6) regarding removal of get_report2_filter(), I think this is not a good idea to remove function by moving its code inline.

Eduards This function is redundant because: a) it's used only in report2.php and cannot be used in other places because it is too specific. b) we do not split filter code in other place (items is exception because filter is very big).

tomtom OK, CLOSED

(7) in Report > Availability report filter in "By Host" mode, when choosing some hostgroup only one host appears in host dropdown.

Eduards RESOLVED r.36400

tomtom REOPENED Not resolved.

Eduards Filter work same as trunk. Host combobox is dependent from hostgroup combobox.. or a problem is in other place?

tomtom CLOSED Looks like before we could choose hosts without triggers but containing items. Now only hosts with triggers will be available.

(8) "filter_groupid" was more appropriate than just "groupid" in report2.php, same applies for "filter_hostid".

Eduards RESOLVED r.36382

tomtom CLOSED

(9) Error on "Monitoring"->"Latest data" page:

Action (Host) does not exist
Invalid argument supplied for foreach() [latest.php:146 → CPageFilter->__construct() → CPageFilter->_initHosts() in branches/dev/ZBX-6693/frontends/php/include/classes/class.cpagefilter.php:506]

Eduards RESOLVED r.36369 When task is in progress state it's is not ready for testing

tomtom CLOSED

(10) in report2.php following scenario:
In filter select hostgroup
select particular host
change to hostgroup to which this host doesn't belong
host dropdown is setted to "all"
no triggers are displayed, all triggers for hostgroup should be displayed

mode: "By Host"

Eduards RESOLVED r.36537

tomtom CLOSED

TESTED

Fixed in versions pre-2.1.0 (beta) r.36546