[ZBX-6706] DM - Cannot create value mapping on master node with same name as existing value map on child node Created: 2013 Jun 14  Updated: 2017 May 30  Resolved: 2013 Jul 24

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.0.4
Fix Version/s: 2.1.0

Type: Incident report Priority: Minor
Reporter: Julien Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: dm, valuemapping
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Distributed Monitoring


Attachments: JPEG File 6706.JPG    

 Description   

When creating a value mapping on the master node, the frontend is checking for duplicate name across all child nodes instead of only master node.



 Comments   
Comment by Oleksii Zagorskyi [ 2013 Jun 15 ]

Just a note - recently there was a "similar" server side fix in ZBX-6333

Comment by Julien [ 2013 Jun 17 ]

I also noticed similar behavior when importing a template on master node and a child node already has same discovery rules.
Should I open separated bug report ?

Eduards Will be better to open separate issue and inside this fix only value mapping.

Comment by Eduards Samersovs (Inactive) [ 2013 Jun 25 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-6706

Comment by Oleg Egorov (Inactive) [ 2013 Jun 27 ]

(1) Row length = 124 in valuemap.inc.php:35

Eduards RESOLVED r.36583

oleg.egorov CLOSED

oleg.egorov adm.valuemapping.php:124 - row length = 129

oleg.egorov REOPEN

And in fixed rows
nodes.inc.php:165, 309

For example

$ZBX_CURMASTERID = $nodeId; // apply master node for this script

Comment in the same row

Eduards RESOLVED r.36648

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Jun 27 ]

(2) Value mapping names without node name (prefix). See 6706.JPG

Eduards RESOLVED r.36583

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(3) Display node names only in All mode.

Eduards RESOLVED r.36598

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(4) Display nodes in separate column.

Eduards RESOLVED r.36600

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(5) Display nodes in Action list.

Eduards RESOLVED r.36648

oleg.egorov See (16)

Eduards RESOLVED r.36779

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(6) Display nodes in Media types list

Eduards RESOLVED r.36693

oleg.egorov See (16)

Eduards RESOLVED r.36779

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(7) Display nodes in Scripts list

Eduards RESOLVED r.36694

oleg.egorov See (16)

Eduards RESOLVED r.36779

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(8) Display nodes in User group list

Eduards RESOLVED r.36695

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(9) Display nodes in User list

Eduards RESOLVED r.36698

oleg.egorov functions in users.inc.php should be documented

Eduards RESOLVED r.36779

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(10) Display nodes in Proxy list

Eduards RESOLVED r.36727

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(11) Display nodes in Image list

Eduards RESOLVED r.36709

oleg.egorov See (16)

Eduards RESOLVED r.36779

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(12) Display nodes in Icon mapping list

Eduards RESOLVED r.36711

oleg.egorov See (16)
Eduards Not necessary, because in foreach loop we do also sorting.

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(13) Display nodes in Regular expression list

Eduards RESOLVED r.36713

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(14) Display nodes in Host group list

Eduards RESOLVED r.36717

oleg.egorov See (16)

Eduards RESOLVED r.36779

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(15) Display nodes in Template list

Eduards RESOLVED r.36721

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(16) Display nodes in Application list

Eduards RESOLVED r.36722

oleg.egorov In applications.php:319-322 foreach loop
In there exist condition:

$data['applications'][$key]['nodename'] = $data['displayNodes']
 ? get_node_name_by_elid($application['applicationid'], true) : '';

And in configuration.application.list.php:88

$this->data['displayNodes'] ? $application['nodename'] : null;

I think better in applications.php add check

if ($data['displayNodes']) {
foreach
}

And in configuration.application.list.php use:

isset($this->data['displayNodes']) ? $application['nodename'] : null,

Eduards RESOLVED r.36779

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 01 ]

(17) Display nodes in Host list

Eduards RESOLVED r.36725

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Jul 08 ]

TESTED!
First part was successfully tested, but task not complete. "Popup" and other places should be fixed in second part.

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 08 ]

Fixed in versions pre-2.2.0 r.36787, pre-2.1.0 (alfa) r.36789

Comment by Alexander Vladishev [ 2013 Jul 10 ]

(18) Cannot update a template:

Template with the same visible name "Template OS Linux" already exists. [templates.php:238 → CAPIObject->update() → CAPIObject->__call() → czbxrpc::call() → czbxrpc::callAPI() → call_user_func() → CTemplate->update() → CTemplate->massUpdate() → CZBXAPI::exception() in /home/sasha/zabbix-svn/trunk/frontends/php/api/classes/CTemplate.php:835] 

Steps to reproduce:

  • open "Template OS Linux" template
  • save

Related issues: ZBX-6781 and ZBX-6782.

Eduards RESOLVED r.36854

oleg.egorov CLOSED
Eduards Fixed in versions 2.2.0 (trunk) r.36864, pre-2.1.1 (alpha) r.36865

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(19) Display nodes in popups

Eduards RESOLVED r.36968

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(20) Display nodes in maintenance

Eduards RESOLVED r.36921

oleg.egorov Please add node name in group filter
Eduards RESOLVED r.37236
oleg.egorov Don't work "Current node" filter

Will be fixed in ZBX-6822

CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(21) Display nodes in screens

Eduards RESOLVED r.36923

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(22) Display nodes in slide shows. Also cannot create slides cross nodes.

Eduards RESOLVED r.37111

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(23) Display nodes in maps

Eduards RESOLVED r.36926

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(24) Display nodes in discovery rules

Eduards RESOLVED r.36927

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(25) Display nodes in items

Eduards RESOLVED r.37095

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(26) Display nodes in item filter

Eduards RESOLVED r.37081

oleg.egorov Should be added node name in navigation bar
Eduards RESOLVED r.37236
oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 11 ]

(27) Display nodes in graphs

Eduards RESOLVED r.37104
oleg.egorov Please add check (if didn't selected node or host group), possible this problem exist and in the other places
Eduards RESOLVED r.37236
oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 18 ]

(28) Display nodes in triggers

Eduards RESOLVED r.37109

oleg.egorov

If select host in filter
Node column still exist

1) Monitoring->Triggerss
2) Configuration->Host>Triggers

Eduards RESOLVED r.37236

oleg.egorov CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 18 ]

(29) Display nodes in web scenarios

Eduards RESOLVED r.37113

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Jul 19 ]

(30) Please add nodes in page filter (select field)
At least in Configuration->Hosts

Eduards RESOLVED r.37236

oleg.egorov Row length > 120 in

applications.php:265,
hostgroups.php: 293, 297, 302
maintenance.php:498, 502

Eduards RESOLVED r.37261

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Jul 23 ]

(31) Display nodes in Monitoring->Web

And don't work "Current node" filter

Eduards RESOLVED r.37261

oleg.egorov Will be fixed in ZBX-6822

CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Jul 24 ]

(32) Display nodes in Configuration->IT Services

Eduards RESOLVED r.37264

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Jul 24 ]

PERFECT, TESTED!

Comment by Eduards Samersovs (Inactive) [ 2013 Jul 24 ]

Fixed in versions 2.1.0 (trunk) r.37271

Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 30 ]

This caused a regression - ZBX-7081.

Generated at Thu Mar 28 11:07:42 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.