[ZBX-6873] Problems with pagination links after performing some action Created: 2013 Aug 09  Updated: 2017 May 30  Resolved: 2013 Oct 03

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.1.2
Fix Version/s: 2.1.5, 2.1.7

Type: Incident report Priority: Blocker
Reporter: Pavels Jelisejevs (Inactive) Assignee: Ivo Kurzemnieks
Resolution: Fixed Votes: 0
Labels: forms, frontend, pagination
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

In some places pagination links work incorrectly after performing some action.

  • In applications after enabling the selected applications, an "Items activated" message appears. The message remains after going to a different page. The same thing happens with LLD rules, item prototypes.
  • In trigger prototypes when going to a different page after a mass operation a "Critical error. Field "parent_discoveryid" is mandatory." error appears.
  • In graph prototypes after saving a graph form or performing a mass operation, the pagination links lead to plain graphs.
  • After saving an LLD rule, going to a different page causes an "Critical error. Field "hostid" is mandatory." error.
  • After saving an item or trigger prototype, going to a different page causes an "Critical error. Field "parent_discoveryid" is mandatory." error.

 Comments   
Comment by Ivo Kurzemnieks [ 2013 Aug 20 ]

The same problems also applied to Screens, Actions, Discovery.
RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6873

Comment by Oleg Egorov (Inactive) [ 2013 Aug 23 ]

(1) Triggers list
Enable element -> select next page

Undefined index: hostid [ in C:\xampp\htdocs\ZBX-6873\frontends\php\triggers.php:447]

iivs RESOLVED in r38279

oleg.egorov After mass update

Undefined index: hostid [ in C:\xampp\htdocs\ZBX-6873\frontends\php\triggers.php:429]
Undefined index: hostid [ in C:\xampp\htdocs\ZBX-6873\frontends\php\triggers.php:450]

REOPEN

iivs RESOLVED in r38281

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Sep 03 ]

(2) Undefined index: templateid [ in C:\xampp\htdocs\ZBX-6873\frontends\php\screenconf.php:294]
Configuration->Screens

iivs RESOLVED in r38290

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Sep 03 ]

(3) Undefined index: hostid [ in C:\xampp\htdocs\ZBX-6873\frontends\php\trigger_prototypes.php:340]
In Trigger prototypes

Select mass update, then cancel

iivs RESOLVED in r38288

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2013 Sep 03 ]

TESTED

Comment by Ivo Kurzemnieks [ 2013 Sep 04 ]

Fixed in pre-2.1.5 (trunk) r38306

Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 09 ]

(4) The same errors have to be fixed in host prototypes. REOPENED.

iivs RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6873 r38350

jelisejev Please review my changes in r38362. Also please note, that we no longer use $_REQUEST directly to access it's values, but get_request() instead.

iivs REVIEWED.
Thanks!
CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 10 ]

TESTED.

Please close (4) before merging.

Comment by Ivo Kurzemnieks [ 2013 Sep 10 ]

Fixed in pre-2.1.5 (trunk) r38370

Comment by Ivo Kurzemnieks [ 2013 Sep 27 ]

(5) REOPEN.
There is annoying bug with paging after deleting something. Every edit form has a delete button. Submit is with JS link that acts the same like GET method simply setting parameters in URL. After deleting an item (host, group, application, etc.) and trying to switch page, the parameters delete=1&form=update still remain in URL. So it's trying to delete same item again on page swithc. This results with an error: "ERROR: No permissions to referred object or it does not exist!".
All forms (host groups, templates, hosts, items, applications and other forms) should be checked.

iivs RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6873 r38877

jelisejev Some issues with the changes to getPagingLine():

  • The $removeUrlParams should only accept arrays;
  • Array type hints should remain;
  • It's better to switch the positions of $urlParams and $removeUrlParams since the latter is used more often.

iivs RESOLVED in r38957

jelisejev I've corrected the code comment in r38962. Please review.

iivs REVIEWED.
Thanks!
CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Oct 03 ]

TESTED.

Please close (5) before merging.

Comment by Ivo Kurzemnieks [ 2013 Oct 03 ]

Fixed in pre-2.1.7 (trunk) r38968

Generated at Sat Apr 20 00:08:50 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.