[ZBX-6904] ESC.HISTORY macro creates different contents (for the same step) when notification sent to multiple recipients Created: 2013 Aug 16  Updated: 2017 May 30  Resolved: 2013 Sep 13

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 2.0.7
Fix Version/s: None

Type: Incident report Priority: Minor
Reporter: Ilin Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: escalations, macros
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

debian7 64bit, zabbix downloaded from official repository (Zabbix server v2.0.7 (revision 37436)), running in VM

Attachments: PNG File 2013-08-16 08_30_55-Configuration of actions.png     PNG File 2013-08-16 08_31_50-Configuration of actions.png     PNG File 2013-08-16 08_32_27-Configuration of user groups.png     PNG File 2013-08-16 08_39_40-Audit actions.png    

 Description   

When using macro

{ESC.HISTORY}

and sending a mail notification to multiple users (group or separate users) the mail contents are not identical.

The first user received ESC.HISOTRY for step 1, however the second one receives for step 2 even though the mail is sent for the same step at the same time.

 Comments   
Comment by richlv [ 2013 Sep 12 ]

(1) when this is resolved, it's probably worth mentioning in upgrade notes. while not significantly, it does change the notification behaviour

igorsh RESOLVED in https://www.zabbix.com/documentation/2.2/manual/installation/upgrade_notes_220

sasha CLOSED

Comment by Igors Homjakovs (Inactive) [ 2013 Sep 13 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-6904

Comment by Andris Zeila [ 2013 Sep 18 ]

(2) possible memory leak when multiple medias (emails) are defined for one user.

Please review my changes in r38584

igorsh Thank you. I accept your modification.

sasha CLOSED

Comment by Andris Zeila [ 2013 Sep 18 ]

(3) escalator.c:860 - subject and message macro substitution is performed without userid. It should be moved in add_object_msg() function where userid is available.

igorsh RESOLVED in r38612

igorsh additional modifications in r38643

wiper removed unused variable, please review 38713

sasha CLOSED

Comment by Andris Zeila [ 2013 Sep 23 ]

Successfully tested

Comment by Igors Homjakovs (Inactive) [ 2013 Sep 23 ]

(4) substitute_simple_macros() in process_recovery_msg() doesn't have userid parameter.

igorsh RESOLVED in r38739

wiper reviewed and CLOSED

Comment by Igors Homjakovs (Inactive) [ 2013 Sep 24 ]

(5) Additional modifications related to recovery message generation.

Please review my changes in r38773.

sasha CLOSED

Comment by Igors Homjakovs (Inactive) [ 2013 Sep 24 ]

(6) Fix for v.2.0 in svn/zabbix/branches/dev/ZBX-6904-2.0

RESOLVED in r38777

Version 2.0 left unchanged.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 25 ]

(7) An incorrect condition action.

if (SUCCEED != check_perm2system(userid))                                                               
        return;                                                                                         
                                                                                                                        
if (EVENT_OBJECT_TRIGGER == event->object && PERM_READ > get_trigger_permission(userid, event->objectid))
        return;

igorsh RESOLVED in r38821

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 25 ]

(8) Line is too long

if (EVENT_OBJECT_TRIGGER == event->object && PERM_READ > get_trigger_permission(userid, event->objectid))

add_message_alert(escalation, event, r_event, action, p->userid, p->mediatypeid, p->subject, p->message);

igorsh RESOLVED in r38819

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 25 ]

(9) Please add a permission check for recovery messages

igorsh RESOLVED in r38821

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 26 ]

(10) Please review my changes in r38827.

igorsh I have reviewed and successfully tested modifications.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 27 ]

(11) fixed resolving of

{ESC.HISTORY}

macro on a recovery event

Please review r38833.

igorsh I have reviewed and successfully tested modifications.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 27 ]

(12) fixed resolving of

{ESC.HISTORY}

macro on internal event

Please review r38836.

igorsh I have reviewed and successfully tested modifications.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Oct 01 ]

Fixed in pre-2.1.7 (trunk) r38845

Generated at Wed Apr 24 21:30:01 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.