[ZBX-6983] triggers w/o events are not shown in screen Created: 2013 Sep 11  Updated: 2017 May 30  Resolved: 2013 Sep 24

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.1.4
Fix Version/s: 2.1.6, 2.1.9

Type: Incident report Priority: Critical
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: events, screens, triggers
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by ZBX-4338 Dashboard's "Last N issues" table ski... Closed

 Description   

triggers w/o events (removed by housekeeper, for example) are not shown in "status of hostgroup triggers" screen element. they are shown in monitoring -> triggers.

interestingly, screen element gets the total count (shown below the list) correctly, but then does not show several triggers



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 18 ]

They are also not displayed in the "Latest 20 issues" widged and the "Status of host triggers" screen element.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 18 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-6983.

Comment by Alexander Vladishev [ 2013 Sep 20 ]

(1) $eventIds this array can be not the associative

jelisejev RESOLVED in r38720.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 20 ]

(2) frontends/php/include/blocks.inc.php:974 the local variable $actions shades the global

jelisejev RESOLVED in r38712.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 20 ]

(3) Broken resolving of

{ITEM.VALUE}

macro in trigger description. Now it works as

{ITEM.LASTVALUE}

.

jelisejev RESOLVED in r38719

sasha REOPENED

  • broken link if trigger URL is not set.
  • better to set nanoseconds in the resolveEventDescription() method call. It will be more clear.

jelisejev RESOLVED in r38744. Also fixed that the trigger severity background was not displayed for triggers without events.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 20 ]

(4) 'selectLastEvent' parameter should contain only used fields (eventid, acknowledged, objectid);
'output' parameter - ('triggerid', 'state', 'error', 'url', 'description', 'priority', 'lastchange')

jelisejev RESOLVED in r38726. The trigger "expression" field is required for macro resolving.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 20 ]

(5) Second API call Trigger()->get() for receiving total quantity of triggers shouldn't contain parameters:

  • selectLastEvent
  • expandDescription
  • output
  • selectHosts
  • ???

jelisejev RESOLVED in r38726.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 20 ]

(6) New lines should not be longer than 120 characters

jelisejev RESOLVED in r38720.

sasha CLOSED

Comment by Alexander Vladishev [ 2013 Sep 20 ]

(7) Please do not use empty() function to check an emptiness of an array

  • frontends/php/include/blocks.inc.php:856
    if (!empty($trigger['lastEvent'])) {

jelisejev RESOLVED in r38721.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 20 ]

(8) Rename the "Status of host group triggers" and "Status of host triggers" screen elements to "Latest host group issues" and "Latest host issues" respectively.

<richlv> hmm. if so, this will change translatable strings, and also require documentation update (docs + screenshots)

jelisejev Yes, it will, but it will be clearer this way.

jelisejev The "Last change" column will also be renamed to "Time".

jelisejev RESOLVED in r38728.

sasha The screen element configuration form - drop-down options should be renamed too. REOPENED

jelisejev RESOLVED in r38745.

sasha CLOSED

Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 23 ]

(9) Document the changes to the "Status of host group triggers" and "Status of host triggers" screen elements.

<richlv> should be documented in corresponding screen sections, screenshots should be updated and it should also be briefly listed in whatsnew

<richlv> list of changes (thanks to pavels for writing proper commit messages ) :

  • changed the "Status of host group triggers" and "Status of host triggers" screen elements and the "Latest 20 issues" to display triggers without events
  • renamed the "Status of host group triggers" element to "Latest host group issues" and "Status of host triggers" to "Latest host issues". Renamed the "Last change" column in these elements to "Time".

jelisejev In (10) we've renamed the screen elements to "Host group issues" and "Host issues".

martins-v Documented in:

RESOLVED.

sasha Thanks! Also renamed these elements in:

RESOLVED

martins-v Looking good to me. CLOSED.

Comment by Alexander Vladishev [ 2013 Sep 24 ]

Frontend has been successfully tested.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 25 ]

Available in 2.1.6 r38789.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Oct 31 ]

(10) After some consideration we've decided that the name "Latest host groups issues" can be misleading, since we can also sort triggers by host and severity. They will be renamed to just "Host group issues" and "Host issues".

jelisejev RESOLVED in r39686.
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Oct 31 ]

Tested!

Comment by Pavels Jelisejevs (Inactive) [ 2013 Oct 31 ]

Fixed in 2.1.9 r39713.

CLOSED.

Generated at Sat Apr 20 10:07:09 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.