[ZBX-7081] Node selection in some pop ups Created: 2013 Sep 30  Updated: 2017 May 30  Resolved: 2013 Oct 15

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.1.6
Fix Version/s: 2.1.8

Type: Incident report Priority: Major
Reporter: Pavels Jelisejevs (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: dm, popups, regression
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

It's now possible to switch nodes in pop ups where it shouldn't be available, for instance, in the item prototype selection pop up when configuring an trigger or graph prototype.

Broken in:

------------------------------------------------------------------------
r37271 | eduards | 2013-07-24 17:07:05 +0300 (Wed, 24 Jul 2013) | 1 line

..F....... ZBX-6706 fixed nodes display
------------------------------------------------------------------------



 Comments   
Comment by Pavels Jelisejevs (Inactive) [ 2013 Sep 30 ]

Same thing in the user and user group selection pop ups in the action configuration forms.

Comment by Vitalij Romanovskij (Inactive) [ 2013 Oct 03 ]

fixed in the development branch svn://svn.zabbix.com/branches/dev/ZBX-7081

Comment by Pavels Jelisejevs (Inactive) [ 2013 Oct 04 ]

(1) The nodes select must also be removed from the following pop ups:

  • item key selection pop up;
  • item selection pop up for template graphs and graph prototypes (including min/max item pop ups);
  • parameter selection pop ups for template screen items;

The logic for the item, trigger or graph selection pop up should be something like: if we only allow to select them from one host or LLD rule, don't show the node select list.

  • script selection pop up in the action configuration form;
  • proxy selection pop up in the action condition configuration form.

If you're not sure if some should contain node selection, check how it works in 2.0.

jelisejev It works differently now:

  • the node drop down is displayed for all pop ups except help items;
  • if a specific host or LLD rule is selected, the drop down is disabled.

RESOLVED in r39130 and r39132.

iivs REOPEN.
There are several issues:

  • Configuration > Actions > Conditions > condition "Node" (use event source triggers or internal) in pop-up it's possible to select nodes.
    Select tag there shouldn't be displayed at all, because there is already a list of nodes.
  • Configuration > Actions > Conditions > condition "Discovery check" in pop-up changing nodes doesn't affect the list.
  • In popup.php: 283 instead of get_request() use getRequest() function.

jelisejev RESOLVED in r39292 and 39293.

iivs REOPEN.
When when changing node in select, the list is empty, although those DRule checks exist.

jelisejev This is a separate issue and will be fixed in ZBX-7152.

iivs Made minor changes in r39304
Please review.

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Oct 09 ]

(2) Another bug: when choosing an item for a template graph on a child node, the local node is selected in the dropdown. The child node must be selected instead.

jelisejev RESOLVED in r39130.

iivs CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Oct 15 ]

(3) Minor change in r39307 and 39308. Please review.

iivs REVIEWED.
Thanks!
CLOSED.

Comment by Ivo Kurzemnieks [ 2013 Oct 15 ]

TESTED.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Oct 15 ]

Fixed in 2.1.8 r39315.

CLOSED.

Generated at Sat Apr 20 02:06:15 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.