[ZBX-7176] Visual flaw caused by selectable space in icons Created: 2013 Oct 20  Updated: 2017 May 30  Resolved: 2014 Dec 17

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.0.9
Fix Version/s: 2.5.0

Type: Incident report Priority: Trivial
Reporter: Marc Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: patch, squashable
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File ZBX-7176-2.0.9-user-select.patch     PNG File ZBX-7176-2.0.9-user-select.png     PNG File now.png     PNG File trigger_log_wizard.png     PNG File was.png     File zbx7176-2.2.5.patch    

 Description   

It's possible to select spaces in/between icons. This may unintentionally happen on double-click.
Since 'user-select' is not part of CSS3 and not supported by ie a combination of CSS (Mozilla/WebKit) and HTML attribute (ie) might be the best way.



 Comments   
Comment by Marc [ 2014 Aug 24 ]

Attached patch zbx7176-2.2.5.patch ports the fix to release 2.2.5.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 16 ]

A better solution would be to remove the "&nbsp" symbol from the span.

Comment by Ivo Kurzemnieks [ 2014 Sep 16 ]

(1) No string changes.

oleg.egorov CLOSED

Comment by Ivo Kurzemnieks [ 2014 Sep 16 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-7176

Comment by Oleg Egorov (Inactive) [ 2014 Sep 16 ]

(2) See was.png and now.png

iivs RESOLVED in r49074

oleg.egorov Please fix, as was been discussed

iivs Nothing to fix any more.
CLOSED.

Comment by Oleg Egorov (Inactive) [ 2014 Sep 18 ]

TESTED

Comment by Ivo Kurzemnieks [ 2014 Sep 18 ]

Spaces in icons have been removed. Note that double-clicking and tripple-clicking means selection of text and it will select all text including empty spaces for nearest sibling elements that are selectable. Something that is strange for webkit browsers.

Fixed in pre-2.5.0 (trunk) r49128

Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 22 ]

(3) The header bar containing these icons became a bit thicker now.

iivs Yes, this was an intentional change. Before objects in the bar were 1px off and seemed like border almost merged with icon, now they have 1px space on top and bottom.

oleg.egorov CLOSED

Comment by Alexander Vladishev [ 2014 Dec 08 ]

(4) Broken headers in "Trigger test" and "Trigger log wizard" forms

iivs As discussed, icons are removed.

RESOLVED in r51143

sasha CHelp class should be removed

REOPENED

iivs RESOLVED in r51207

sasha Great work! CLOSED

Comment by Ivo Kurzemnieks [ 2014 Dec 17 ]

Help icons are now removed from pop-ups: trigger log wizard pop-up form, trigger expression test pop-up form and bar report item pop-up form.

Fixed in pre-2.5.0 (trunk) r51227

Comment by Alexander Vladishev [ 2014 Dec 17 ]

Screenshots in the documentation will be updated before release of 3.0.0.

Generated at Tue Apr 16 12:30:25 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.