still there in 2.2.0

(1) related : have action operation that sends to user and user group. delete user - whole operation is deleted. should not happen.

gunarspujats RESOLVED in r55712.

oleg.egorov CLOSED

ZBXNEXT-551 talks about warnings in case anything an action references is deleted

ZBX-7948 is related (asks to document cases when action can be disabled)

(2) [A] Added translation strings:

• Action disabled due to deletion of user.
• Action disabled due to deletion of user group.

oleg.egorov CLOSED

<richlv> actual added translation string is "Action disabled due to deletion of user", without trailing dot - is that good ?

gunarspujats RESOLVED in r56416.

oleg.egorov Thank you, Rich! CLOSED

RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-7202

(3) Coding style:

• Function description should be ended with a dot (CAction.php:2250, 2270);
• Function descriptions and params should be separated by blank line (CAction.php:2251);
• We don't use "empty" in conditions (CAction.php:2267);
• Unnecessary tabs in CAction.php:2269-2270.

As example

Now:

	/**
	 * Disable actions
	 * @param array $actionids
	 */

Correct:

	/**
	 * Disable actions.
	 * 
	 * @param array $actionids
	 */

• And as discussed don't use "public" for disableActions and disableActionsWithoutOperations functions.
• Please change public methods for validateCreate and validateUpdate to protected.

gunarspujats RESOLVED in r55774.

oleg.egorov Other issues:

• $dbOperations - used camelCases, but should be $db_operations

REOPENED

gunarspujats RESOLVED in r55802.

oleg.egorov testFormAdministrationUserCreate.php

• Two blank lines after licence comment.
• Use single quote instead of a double

Now:

$this->click("id=add_group");

REOPENED

gunarspujats RESOLVED in r55892.

oleg.egorov

• Function disableActions

  protected function disableActions(array $actionids) {
  	if ($actionids) {
  		// Function action.
  	}
  }
  

  Should be changed to:

  protected function disableActions(array $actionids) {
  	// Function action.
  }
  

  And $actionids check should be before function call

• Same issue exist in disableActionsWithoutOperations, disableActionsWithoutOperations should be executed only with $actionids

REOPENED

gunarspujats RESOLVED in r56376.

oleg.egorov Variable naming
$empty_actions sounds like boolean, but there is ID's array

gunarspujats RESOLVED in r56383.

oleg.egorov CLOSED

(4) Please add operation id for disableActionsWithoutOperations, to improve performance

gunarspujats RESOLVED in r55774.

oleg.egorov As was discussed with oleg.egorov,iivs, ingus.vilnis, dimir and gunarspujats in audit log should be added details, why was disabled action.

And code from actions.inc.php (disableActionsWithoutOperations and disableActions) should be moved to CUser.php and CUserGroup.php

gunarspujats RESOLVED in r55948.

oleg.egorov CLOSED

Fixed in:

• pre-3.0.0alpha4 (trunk) r56387

(5) API documentation:

• API changes from 2.4 to 3.0

oleg.egorov CLOSED