[ZBX-7250] PHP gettext extention should be optional Created: 2013 Oct 30  Updated: 2017 May 30  Resolved: 2014 Feb 03

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F), Installation (I)
Affects Version/s: 2.1.9
Fix Version/s: 2.2.1rc1, 2.3.0

Type: Incident report Priority: Blocker
Reporter: Ivo Kurzemnieks Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: frontend, gettext, setup
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File error.png     PNG File pre-requisites.png    

 Description   

In setup PHP gettext should be optional - removed from "step 2. Check of pre-requisites" module list. It is not required. System works without it, only translations will not work.
Due to this, frontend messages should also be then removed, but not all. Only place to show error message should be where we select language - in profiles.
We shouldn't be allowed change or select different language, if gettext module is disabled. Probably in dropdown they can be marked as disabled and/or maked as red.

 Comments   
Comment by richlv [ 2013 Oct 30 ]

if we do that, better let's have another section 'warnings' and list gettext as missing there, then explain what are the consequences

edit : we would also have to take care of that in the status of zabbix block/report

Comment by Pavels Jelisejevs (Inactive) [ 2013 Nov 11 ]

(1) Documentation needs to be updated.

jelisejev Added it to the what's new section https://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew221

martins-v Copied to https://www.zabbix.com/documentation/2.2/manual/installation/install#step_2 as well.

Also noted that gettext is required with language choice:

martins-v CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2013 Nov 11 ]

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-7250.

Comment by Eduards Samersovs (Inactive) [ 2013 Nov 12 ]

Tested

Comment by Pavels Jelisejevs (Inactive) [ 2013 Nov 13 ]

Fixed in 2.2.1rc1 r40240 and 2.3.0 r40241.

Comment by richlv [ 2013 Nov 21 ]

(2) sorry, have to complain a bit
we should not remove gettext from requirements step in the wizard, instead it should be listed there but in orange or whatever and we should explain that locales won't be available.

jelisejev RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-7250.

Short change summary:

  • setup now supports optional checks;
  • failed optional checks will be displayed in orange with a "Warning" status label, instead of "Fail";
  • if an optional check has failed, the green OK status will be displayed and the setup will can continue, but a "(with warnings)" note will be displayed right under "OK".

Eduards CLOSED, please review r.40567

jelisejev Everything OK, thanks.

Comment by Eduards Samersovs (Inactive) [ 2013 Nov 28 ]

(3) Will be nice to set proper border-color for .orange .fail and other classes

jelisejev RESOLVED in r40569. I didn't add the border for the .blue class, because it's used only in a couple of places.
Eduards CLOSED

Comment by Eduards Samersovs (Inactive) [ 2013 Nov 28 ]

Tested!

Comment by Pavels Jelisejevs (Inactive) [ 2013 Nov 28 ]

Fixed in 2.2.1rc1 r40580 and 2.3.0 r40581.

CLOSED.

Comment by richlv [ 2013 Nov 29 ]

(4) whatsnew should be updated with screenshots of wizard & "status of zabbix"
possibly installation screenshot with requirement check page should be updated. too

jelisejev I don't think we need a special screenshot for that, but Martins should decide.

martins-v I decided to describe generally how failed optional prerequisites will look in the list: https://www.zabbix.com/documentation/2.2/manual/installation/install#step_2. RESOLVED.

<richlv> i would still like to see a screenshot, but we can do without it for now. after minor formatting fixes, CLOSED

Comment by Oleg Ivanivskyi [ 2014 Jan 31 ]

Please look screenshots.

Comment by Oleg Ivanivskyi [ 2014 Jan 31 ]

Error "Field "lang" is mandatory." when trying to create or update a user.

<richlv> i'd suggest opening a new zbx, because this issue was already merged for 2.2.1

Comment by Oleg Ivanivskyi [ 2014 Feb 03 ]

Created ZBX-7743.

Generated at Fri Apr 19 11:42:50 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.