[ZBX-7288] proxy tries to process failed response from server Created: 2013 Nov 05  Updated: 2017 May 30  Resolved: 2013 Dec 19

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: 2.1.9
Fix Version/s: 2.2.2rc1, 2.3.0

Type: Incident report Priority: Major
Reporter: richlv Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: regression
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

if proxy asks for config data from the server but there is no proxy with such name, previously we would log a message "Proxy host name might not be matching that on the server."

now it's :

979:20131105:160656.160 Received configuration data from server. Datalen 23
979:20131105:160656.160 failed to update local proxy configuration copy: Can't open JSON object or array ""failed"}"

even the first message here should not appear, it should only be logged when actual received data is ok

 Comments   
Comment by Andris Mednis [ 2013 Nov 06 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-7288 .

Comment by Andris Zeila [ 2013 Nov 11 ]

(1) It would be nice to send back the error description in info field and write it into logs.
andris It was decided that sending the error description and writing it into receiver's log should be implemented for all types of data transfer between active proxy and server.

wiper CLOSED

Comment by Andris Mednis [ 2013 Nov 12 ]

(2) It was decided that the error description should use dynamically allocated memory instead of a fixed size 256-byte buffer.
andris Available in svn://svn.zabbix.com/branches/dev/ZBX-7288 r40883.
andris CLOSED

Comment by Andris Mednis [ 2013 Nov 13 ]

Reopening because requirements have changed.

Comment by Andris Mednis [ 2013 Dec 09 ]

Available in the development branch svn://svn.zabbix.com/branches/dev/ZBX-7288.

Comment by Andris Zeila [ 2013 Dec 09 ]

(3) Regarding zbx_recv_response_dyn(zbx_sock_t *sock, char **info, char **error, int timeout) function. I'm not sure about changing the name - usually _dyn is appended if we have already function working with static buffers with the same name.

But the error output parameter usually is the last one. I think it would be good to keep this pattern.
andris RESOLVED in r40878.

wiper CLOSED

Comment by Andris Zeila [ 2013 Dec 09 ]

(4) Please review my changes in r40858
andris Thanks! Reviewed and accepted. Minor improvements in r40873.

wiper CLOSED

Comment by Andris Zeila [ 2013 Dec 09 ]

(5) Warning messages should keep <variable>:<value> pattern instead of <variable>=<value>
andris RESOLVED in r40883.

wiper CLOSED

Comment by Andris Zeila [ 2013 Dec 10 ]

Successfully tested

Comment by Andris Mednis [ 2013 Dec 12 ]

(6) Added an error message for active/passive proxy misconfiguration case in r40922.

wiper CLOSED

Comment by Andris Mednis [ 2013 Dec 13 ]

(7) get_proxy_id() changed to get_active_proxy_id() in r40952.

wiper CLOSED

Comment by Andris Zeila [ 2013 Dec 14 ]

Successfully tested

Comment by Andris Mednis [ 2013 Dec 14 ]

Fixed in versions pre-2.2.2 rev. 40975 and pre-2.3.0 rev. 40977.

Comment by richlv [ 2013 Dec 16 ]

(8) this was also listed by andris at https://www.zabbix.com/documentation/2.2/manual/introduction/whatsnew222#daemon_improvements -> CLOSED

Comment by richlv [ 2013 Dec 19 ]

reopen to restore label

Generated at Wed Apr 24 17:20:50 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.