[ZBX-7459] incorrect regexp saving and testing Created: 2013 Nov 29  Updated: 2017 May 30  Resolved: 2014 Jul 09

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: API (A), Frontend (F)
Affects Version/s: 2.2.0
Fix Version/s: 2.3.2

Type: Incident report Priority: Critical
Reporter: richlv Assignee: Martins Valkovskis
Resolution: Fixed Votes: 0
Labels: globalregexps, regexps
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File global_regexps.png     PNG File regression.png    
Issue Links:
Duplicate

 Description   

-------- testcase 1

create new global regexp, regexp " 1" and test string " 1" (without quotes). observe how editing the regexp still has the leading space.
save the global regexp, open it - observe space missing from both regexp & test string

-------- testcase 2

create global regexp "^ 1" and test string " 1". test it. notice how it fails. should not.



 Comments   
Comment by Oleksii Zagorskyi [ 2013 Nov 30 ]

If you will touch it, then see also ZBX-5902

Comment by Andrejs Čirkovs (Inactive) [ 2014 Jun 10 ]

RESOLVED in r46337.

Comment by Ivo Kurzemnieks [ 2014 Jun 25 ]

(1) In regular expressions list view the column "Expressions" should display data with "pre" class also. Otherwise everything is clumped together.

andrewtch RESOLVED by r46818.

iivs REOPENED.
For very long expressions list view and edit mode can be broken. I suggest to use "pre-wrap".
When using "pre-wrap" in list view for other columns, it would be good to use "vertical-align: top".
See attached image.

andrewtch RESOLVED by r46864. Please note that I've also added new class, 'break-lines' for the cases if we have really brutal regular expression without spaces. Also, I've removed repeated definition of td.pre since we already have global .pre class.

iivs CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Jun 26 ]

TESTED.

Comment by Andrejs Čirkovs (Inactive) [ 2014 Jun 26 ]

CLOSED in pre-2.3.2 r46872.

Martins, please document this.

martins-v Mentioned in https://www.zabbix.com/documentation/2.4/manual/introduction/whatsnew240#miscellaneous_improvements

Comment by Oleg Egorov (Inactive) [ 2014 Jul 03 ]

(2) Regression
Maps links displaying.

See regression.png

andrewtch RESOLVED in development branch svn://svn.zabbix.com/branches/dev/ZBX-7459 r47030.

oleg.egorov CLOSED

Comment by Andrejs Čirkovs (Inactive) [ 2014 Jul 04 ]

CLOSED, fixed in pre2.3.2 r47046.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jul 07 ]

(3) It would be great to document that slashed are interpreted as literal symbols, not delimiters.

martins-v Added to https://www.zabbix.com/documentation/2.4/manual/introduction/whatsnew240#miscellaneous_improvements (see last bulletpoint). Please review.

andrewtch CLOSED, fine.

<richlv> seems to be listed in whatsnew only, which means that it will disappear later - couldn't find it in https://www.zabbix.com/documentation/2.4/manual/regular_expressions
REOPENED

martins-v Added to https://www.zabbix.com/documentation/2.4/manual/regular_expressions#configuration as well. RESOLVED.

Comment by Andrejs Čirkovs (Inactive) [ 2014 Jul 11 ]

Thanks, CLOSED

Generated at Fri Mar 29 17:52:22 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.