other item keys where we support regexps and that probably should be verified :
- system.hw.macaddr
- system.sw.packages
- vfs.file.regexp
- vfs.file.regmatch
- web.page.regexp
- snmptrap
ZBX-5902 is related.
For example both issues could be fixed together.
This is being fixed as part of solution in ZBXNEXT-2430.
I close the issue as duplicate of ZBXNEXT-2430.
Processing of rRegular expressions in eventlog[] items should be fixed too.
Turns out ZBXNEXT-2430 fixed it for log and logrt[], but forgot about eventlog (see process_eventlog_check()). Makes sense to reopen and fix. Example how it is done is in zbx_read2().
Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-7602
(1) Stylistically, lines should be 120 characters at most (see https://www.zabbix.org/wiki/C_coding_guidelines).
s.paskevics RESOLVED in r61513
asaveljevs Some lines are still longer than 120 characters. REOPENED.
s.paskevics RESOLVED in r61569
asaveljevs CLOSED
(2) The old "if"s seem to have required all things to match, but the new code only requires one thing to match.
s.paskevics RESOLVED in r61513
asaveljevs There must be a shorter way of doing this. 
REOPENED.
s.paskevics RESOLVED in r61569
asaveljevs Can you make it shorter still? Also, "ret_regexp_value" and other variables are not needed outside that "0 == p_count" if. REOPENED.
s.paskevics RESOLVED in r61666
asaveljevs Looks good, but please see some further suggestions in r61682. TESTED.
s.paskevics Ok. CLOSED
(3) In case there is an invalid regular expression, we do not call finalize_eventlog6().
s.paskevics RESOLVED in r61569
asaveljevs CLOSED
(4) One consideration is that we should only check regular expression validity once. After we know that regular expressions are valid, we should try to do as few checks as possible.
s.paskevics RESOLVED in r61569
asaveljevs CLOSED
(5) It is not related to this development, but the Windows compiler warns about the following:
..\..\..\src\zabbix_agent\active.c(1142) : warning C4244: '=' : conversion from 'double' to 'float', possible loss of data
s.paskevics RESOLVED in r61569
asaveljevs According to https://www.zabbix.org/wiki/C_coding_guidelines , no space should be added after the type when casting. REOPENED.
s.paskevics RESOLVED in r61666
asaveljevs As discussed on IRC, it seems dubious to have "max_delay" variable (introduced in ZBXNEXT-2430) as float, because we cast it to double in several places anyway, but OK - let's leave as is. CLOSED.
I did some alternative implementation in svn://svn.zabbix.com/branches/dev/ZBX-7602-alt . If you like it, feel free to use it for further development.
(6) Currently, if there is an invalid regular expression, we complain without pointing to the offending expression. Do we want to specify exactly which one is bad?
s.paskevics RESOLVED in r61569
asaveljevs CLOSED
Fixed in:
- pre-3.2.0 (trunk) r61690