trigger-prototype.png
[ZBX-7708] minor presentation issues regarding errors when editing triggers Created: 2014 Jan 27 Updated: 2017 May 30 Resolved: 2014 Feb 10 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | API (A), Frontend (F) |
| Affects Version/s: | 2.0.11rc1 |
| Fix Version/s: | 2.0.12rc1, 2.2.3rc1, 2.3.0 |
| Type: | Incident report | Priority: | Trivial |
| Reporter: | Aleksandrs Saveljevs | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | triggers | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
trigger-prototype.png
|
| Description |
|
(A) Try to create a trigger prototype without a reference to item prototype. See trigger-prototype.png. The error message says: "Trigger "trigger prototype without item prototype: {13607}#1" does not have item prototype."First, it should say "Trigger prototype ..." instead of just "Trigger". Second, it should provide a human-readable reference to the item, instead of "{13607} ". (B) Try to edit an existing trigger and change its name so that pressing "Save" fails (for instance, the trigger becomes identical to another existing trigger). Pressing "Save" fails, which is good, but note that trigger name is back to the old value. |
| Comments |
| Comment by Oleg Egorov (Inactive) [ 2014 Feb 07 ] |
|
B - problem will be fixed in 2.2 and trunk |
| Comment by Oleg Egorov (Inactive) [ 2014 Feb 07 ] |
|
FIXED IN svn://svn.zabbix.com/branches/dev/ZBX-7708 r42408 |
| Comment by Eduards Samersovs (Inactive) [ 2014 Feb 10 ] |
|
(1) We can optimize CTriggerPrototype::create() to not use explode_exp(), because we have full trigger expression in the input data. oleg.egorov RESOLVED IN r42460 |
| Comment by Eduards Samersovs (Inactive) [ 2014 Feb 10 ] |
|
(2) Will be nice to move line from forms.inc.php:1260 to forms.inc.php:1306 oleg.egorov RESOLVED IN r42460 |
| Comment by Eduards Samersovs (Inactive) [ 2014 Feb 10 ] |
|
Tested |
| Comment by Oleg Egorov (Inactive) [ 2014 Feb 12 ] |
|
FIXED IN 2.0.12rc1 r42548, 2.2.3rc1 r42549, 2.3.0(trunk) r42553 CLOSED |
| Comment by richlv [ 2014 Feb 13 ] |
|
for the record, we changed translatable strings for 2.0 here. not sure that's something we will want to continue doing long term |