[ZBX-7720] Can not add long name virtual machine by vmware discovery Created: 2014 Jan 29  Updated: 2018 Nov 23  Resolved: 2014 Jul 21

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Server (S)
Affects Version/s: 2.2.1
Fix Version/s: 2.3.4

Type: Incident report Priority: Major
Reporter: Yuya Kusakabe Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: database, vmware
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Zabbix 2.2.1, vCenter 5.0 u3


Attachments: Text File zabbix-2.2.1-fix-long-host-name.patch    
Issue Links:
Duplicate
is duplicated by ZBX-8594 64 char hostname limit and RFC 1123 Closed

 Description   

Max of host name should increase 128 for the following reasons.

Attached is my patch.



 Comments   
Comment by Yuya Kusakabe [ 2014 May 02 ]

This is my patch for 2.2.2.
https://gist.github.com/higebu/9826325

Comment by Alexander Vladishev [ 2014 Jul 21 ]

(1) [F] String changes

  • Removed strings:
    • Maximum host name length is %1$d characters, "%2$s" is %3$d character.
    • Maximum host name length is %1$d characters, "%2$s" is %3$d characters.
    • Maximum visible host name length is %1$d characters, "%2$s" is %3$d character.
    • Maximum visible host name length is %1$d characters, "%2$s" is %3$d characters.

kristsk CLOSED.

sasha REOPENED

  • Removed strings:
    • Maximum host name length is %1$d characters, "%2$s" is %3$d character.
    • Maximum host name length is %1$d characters, "%2$s" is %3$d characters.
    • Maximum visible host name length is %1$d characters, "%2$s" is %3$d character.
    • Maximum visible host name length is %1$d characters, "%2$s" is %3$d characters.
    • Maximum alias length is %1$d characters, "%2$s" is %3$d character.
    • Maximum alias length is %1$d characters, "%2$s" is %3$d characters.
    • Maximum DNS name length is %1$d characters, "%2$s" is %3$d character.
    • Maximum DNS name length is %1$d characters, "%2$s" is %3$d characters.
Comment by Alexander Vladishev [ 2014 Jul 21 ]

Increased size of proxy name, host name and host visible name to 128 characters. Added upgrade patches.

Ready for testing.

Comment by Alexander Vladishev [ 2014 Jul 21 ]

Available in the development branch svn://svn.zabbix.com/branches/dev/ZBX-7720

Comment by dimir [ 2014 Jul 23 ]

I propose to set correct error message if host name is invalid. See my changes in r47563. Other than that server side and upgrade are tested.

Comment by Krists Krigers (Inactive) [ 2014 Aug 04 ]

(2) Other possibly redundant string length checks:
Result of

grep --include=*.php -R "'Maximum .* length" *

shows that there other places where string length is validated directly in API.

sasha RESOLVED in r47808.

kristsk CLOSED.

Comment by Krists Krigers (Inactive) [ 2014 Aug 05 ]

TESTED

Comment by Alexander Vladishev [ 2014 Aug 06 ]

Available in pre-2.3.4 (trunk) r47843.

Comment by Łukasz Jernaś [ 2014 Oct 02 ]

Couldn't we change that to 255 ?

Comment by Alexander Vladishev [ 2014 Oct 02 ]

Łukasz,

Please create an another ZBXNEXT with this request. For what purposes it is necessary? Examples?

Comment by dimir [ 2018 Nov 23 ]

The docs still mention Hostname maximum length as 64:

https://www.zabbix.com/documentation/4.0/manual/appendix/config/zabbix_agentd

Shouldnt' they be updated?

Generated at Thu Mar 28 17:23:59 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.