[ZBX-7821] Impossible to choose item type information as numeric for log item with number extraction Created: 2014 Feb 17 Updated: 2017 May 30 Resolved: 2015 Jul 30 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | 2.2.2 |
Fix Version/s: | 2.5.0 |
Type: | Incident report | Priority: | Blocker |
Reporter: | Alexey Pustovalov | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 7 |
Labels: | graphs, log, logmonitoring, patch, unsquashable, usability | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified | ||
Environment: |
Log items |
Attachments: | ZBX-7821-2.2.4.patch | ||||
Issue Links: |
|
Description |
Since 2.2 version Zabbix can extract a value from a log file using <output> parameter. So it is possible to extract numeric values, but graphs for numeric values are not available, because there is no possible to change type of information to Numeric (unsigned or double). |
Comments |
Comment by richlv [ 2014 Feb 17 ] |
we left zalex_ua let me disagree See comment below. |
Comment by Oleksii Zagorskyi [ 2014 Mar 28 ] |
I believe this is an issue which should be fixed. |
Comment by Oleksii Zagorskyi [ 2014 Mar 28 ] |
I think we could resolve it: add an additional Javasript pop-up confirmation dialog when user tries to save numeric item with type log. |
Comment by Marc [ 2014 Mar 28 ] |
Does that mean it's limited by the frontend only and not by the corresponding API call? |
Comment by Oleksii Zagorskyi [ 2014 Mar 28 ] |
Marc, no, API doesn't allow to create numeric item with key in log, logrt, eventlog |
Comment by Marc [ 2014 Mar 29 ] |
Then I don't understand how a pop-up may help in this context. This functionality is needed quite often and I would appreciate to see it implemented. |
Comment by Oleksii Zagorskyi [ 2014 Apr 01 ] |
I tried to change "value_type" in "items" table from 2 (log) to 3 (unsigned integer) directly in database. An it works (C)! So seems there isn't any other limitation than a sanity check in frontend to not allow numeric type for log* items. But now we can improve this limitation. Another approach: if log* item key contains 6th parameter (<output>) then allow to store it as numeric item type. |
Comment by Oleksii Zagorskyi [ 2014 Apr 24 ] |
It's possible to "hacks" log items (as I mentioned above) at template level. |
Comment by Robert Hau [ 2014 Apr 25 ] |
This improvement is a no brainer in my mind. If you are collecting metrics from a log its great to be able to graph it. |
Comment by Pavels Jelisejevs (Inactive) [ 2014 May 08 ] |
To fix this we'll need to separate log items from other item types. This is not something we can do during bugsquashing. zalex_ua I don't see much difference with "vfs.file.regexp[file,regexp,<encoding>,<output>]" key which is allowed to be saved as any item type ... |
Comment by Marc [ 2014 Jul 17 ] |
|
Comment by Marc [ 2014 Jul 18 ] |
When getting implemented, then something like ZBXNEXT-2387 might be beneficial. |
Comment by Oleksii Zagorskyi [ 2015 Apr 30 ] |
One thing I forgot at all is graphing values with unpredictable interval of values. Of course it's possible to play with definitions: define('ZBX_GRAPH_MAX_SKIP_CELL', 16); define('ZBX_GRAPH_MAX_SKIP_DELAY', 4); (discussed a bit also in https://support.zabbix.com/browse/ZBXNEXT-2230#comment-48469) But if for example I want to catch *log values as fast possible and set item update interval to 1 second? Also remember that ZBX_GRAPH_MAX_SKIP_CELL used in an estimation where from to get data - from history or trends. |
Comment by Ivo Kurzemnieks [ 2015 Jun 09 ] |
(1) Removed translation strings:
oleg.egorov CLOSED |
Comment by Ivo Kurzemnieks [ 2015 Jun 09 ] |
RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-7821 |
Comment by Oleksii Zagorskyi [ 2015 Jun 10 ] |
just for a record - solution is simple - r54000 says "removed restriction for log, logrt and eventlog items to be with information type numeric" iivs I might've said this incorrectly. What I meant is, I removed the restriction to have log type information for items with key "log", "logrt" and "eventlog". So now those items can now have numeric type of information. |
Comment by Oleg Egorov (Inactive) [ 2015 Jun 30 ] |
TESTED |
Comment by Ivo Kurzemnieks [ 2015 Jul 01 ] |
Restriction removed. It's now possible to have any type of information for items and item prototypes with key "log", "logrt" and "eventlog" Fixed in pre-2.5.0 (trunk) r54244 |
Comment by Martins Valkovskis [ 2015 Jul 02 ] |
(2) Documented in:
RESOLVED. sasha Looks good! CLOSED <richlv> it seems like choosing non-"Log" information type will lead to a loss of local timestamp in case of all log items and also log severity & source in case of the eventlog item. that should be mentioned. local timestamp is also lost when using output, but that's a separate bugreport - ZBX-9610 martins-v Notes added to:
Please review if they're correct. <richlv> if i read it right, we should probably also mention local timestamp for the eventlog key martins-v Right, done that: https://www.zabbix.com/documentation/3.0/manual/config/items/itemtypes/zabbix_agent/win_keys RESOLVED. <richlv> thanks, CLOSED |
Comment by richlv [ 2015 Jul 24 ] |
note that this mostly duplicated/implemented ZBXNEXT-89 |
Comment by richlv [ 2015 Jul 24 ] |
another thing to note is that the eventlog key does not seem to support 'output' parameter at this time, thus non-log information type for it does not seem to be necessary - but i guess it was simpler to remove the restriction for all log items in one go |
Comment by Oleksii Zagorskyi [ 2015 Sep 14 ] |
Another point which was mentioned on a training - values for such log items may come with very different intervals. Or for such items we would need to use use the same graphing logic as for trapper items ? ..... I don't know .... |
Comment by Aleksandrs Saveljevs [ 2015 Nov 19 ] |
This introduced a bug, see |