[ZBX-8188] Zabbix server continue to retrieve values from IPMI agent even if the machine is shutdown state Created: 2014 May 08 Updated: 2017 May 30 Resolved: 2014 May 12 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Proxy (P), Server (S) |
Affects Version/s: | 2.0.11, 2.2.3 |
Fix Version/s: | 2.0.13rc1, 2.2.4, 2.3.2 |
Type: | Incident report | Priority: | Minor |
Reporter: | Kodai Terashima | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | ipmi | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
Description |
Zabbix server and proxy continue to retrieve values from IPMI sensors even if the machine is shutdown state. ipmitools return "na" for such case. IPMI device return values with sensor status but Zabbix doesn't check the status. According to IPMI 2.0 specification, IPMI client should check sensor status before getting value. IPMI item should be not-supported state in that case. |
Comments |
Comment by Aleksandrs Saveljevs [ 2014 May 08 ] |
kodai I guess these are different issue. this is problem when monitored machine is stopped (shutdown), |
Comment by Nikolajs Agafonovs (Inactive) [ 2014 May 12 ] |
Fix available in svn://svn.zabbix.com/branches/dev/ZBX-8188 |
Comment by Aleksandrs Saveljevs [ 2014 May 16 ] |
Kodai, could you please provide a reference to IPMI 2.0 specification where it says about checking sensor status? kodai I checked ipmitool source (ipmitool return n/a for stopped device), haven't checked IPMI 2.0 specification. will try to find it from the specification. |
Comment by Aleksandrs Saveljevs [ 2014 May 19 ] |
Alternative solution is available in the same development branch: svn://svn.zabbix.com/branches/dev/ZBX-8188 . It uses functions ipmi_is_sensor_scanning_enabled() and ipmi_is_initial_update_in_progress() as previously suggested by Kodai. |
Comment by Kodai Terashima [ 2014 May 27 ] |
According to page 464 on http://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/second-gen-interface-spec-v2.pdf, Table 35-15, Get Sensor Reading Command 3rd bit of response data:
|
Comment by dimir [ 2014 Jun 02 ] |
Another one from the same doc regarding "sensor scanning enabled":
|
Comment by dimir [ 2014 Jun 02 ] |
(1) [S] As I understood from the above mentioned document, the "initial update in progress" and "sensor scanning disabled" means in general that the sensor data is not available (either not yet ready or entity does not exist). So I suggest to simplify the error message for the user like this: if (0 == ipmi_is_sensor_scanning_enabled(states)) { - h->err = zbx_strdup(h->err, "sensor scanning is not enabled"); + h->err = zbx_strdup(h->err, "sensor data is not available"); @@ -376,7 +376,7 @@ if (0 != ipmi_is_initial_update_in_progress(states)) { - h->err = zbx_strdup(h->err, "initial update is in progress"); + h->err = zbx_strdup(h->err, "sensor data is not available"); Please see my suggestion in r46099. asaveljevs Looks good, CLOSED. |
Comment by dimir [ 2014 Jun 02 ] |
Other than that the issue is tested. |
Comment by Aleksandrs Saveljevs [ 2014 Jun 03 ] |
(2) There was a conflict merging from 2.0 into 2.2 because the newer version has discrete sensor support. Resolved conflicts are available in development branch svn://svn.zabbix.com/branches/dev/ZBX-8188-2.2 . Please take a look. dimir Looks good. Please see my suggestions to simplify the code a bit in r46134. RESOLVED asaveljevs Great! CLOSED. |
Comment by Aleksandrs Saveljevs [ 2014 Jun 03 ] |
Fixed in pre-2.0.13 r46114, pre-2.2.4 r46164, pre-2.3.2 (trunk) r46165. |