[ZBX-8377] Blue input fields in dark orange theme Created: 2014 Jun 20  Updated: 2017 May 30  Resolved: 2014 Aug 20

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.3.2
Fix Version/s: 2.3.3, 2.3.4

Type: Incident report Priority: Trivial
Reporter: Oleg Egorov (Inactive) Assignee: Ivo Kurzemnieks
Resolution: Fixed Votes: 0
Labels: regression, themes
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File disabled.png     PNG File do_forms.png     PNG File do_search.png    

 Comments   
Comment by Ivo Kurzemnieks [ 2014 Jun 27 ]

(1) No translation strings changed.

oleg.egorov CLOSED

Comment by Ivo Kurzemnieks [ 2014 Jun 27 ]

Regression from ZBX-8329

RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-8377

Comment by Oleg Egorov (Inactive) [ 2014 Jun 27 ]

(2) Please fix disabled select fields, as was discussed

iivs Fixed IE problems for <select> tags and button hovers for all themes.
RESOLVED in r46937

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2014 Jun 30 ]

(3) Original blue theme, Monitoring->Events page, incorrect text color for readonly input fields

iivs RESOLVED in r46968

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2014 Jun 30 ]

(4) Classic theme, please add background color for input fields, something like #eee
And change text color to ~ #3c3c3c

As was discussed, readonly and disabled fields should be more readable

iivs RESOLVED in r46969

iivs As we last discussed, I made some refinements in classic theme. See r47026

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2014 Jul 02 ]

(5) Revert select fields background color in dark orange theme.
Use ~ #333-#444 border color for disabled and readonly fields

See disabled.png
1) enabled
2) disabled

iivs RESOLVED in r47034

iivs Fixed disabled multiselect hover r47041

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2014 Jul 04 ]

TESTED

Comment by Ivo Kurzemnieks [ 2014 Jul 04 ]
  • Dark orange theme input fields are no longer displayed light blue;
  • Disabled submit button hovers no longer have hover shadows;
  • All readonly and disabled input fields, including selects are now more readable on all browsers in all themes

Fixed in pre-2.3.2 (trunk) r47052

Comment by Pavels Jelisejevs (Inactive) [ 2014 Jul 07 ]

(6) Please check with Martins if any screenshots need to be updated.

martins-v I can't think of any right now. CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Aug 15 ]

(7) The text of disabled "Go" and action buttons is now almost the same as for enabled. Please see if we can make it lighter.

Also, these buttons shouldn't have a hover effect.

iivs Text color was made this way to be close enough as it is in all of different IE versions. I made them lighter same as they were before in 2.2, but since there are 50 different shades of gray, some IEs (like 8) will display text fields slightly different from select fields and there's nothing we can do about it. And hover effect is fixed.

RESOLVED in r48247

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Aug 15 ]

(8) In the classic theme disabled input fields are barely distinguishable from enabled. Can we make the background color darker?

iivs Making background, at least by a small notch darker, will merge with already existing gray background or merge with text and it will become unreadable again. For instance if look at old Windows forms for example, we see that there is gray color layered on top of another gray color, but what makes it look acceptable, is that it has input field shadows and text shadows, so fields are distinguishable and text is readable. Some IE versions have that text shadow by default for disabled fields, but on pixel perfect browsers classic theme with gray fields, borders, backgrounds and texts just doesn't look good. I tried to fix this, but I don't know if it looks any good.

RESOLVED in r48247

jelisejev I've made the border color for readonly input fields a bit lighter in r48411.

iivs Thanks! I did the same for disabled input fields, like we discussed.

CLOSED.

Comment by Alexander Vladishev [ 2014 Aug 18 ]

(9) Text in the read-only fields in "Classic", "Original blue" and "Black & blue" themes are displayed in gray color. Black color was more readable.

iivs Note: Black and blue theme had white text for readonly fields.

RESOLVED in r48247

jelisejev CLOSED.

Comment by Pavels Jelisejevs (Inactive) [ 2014 Aug 26 ]

TESTED.

Please have a look at (8) before merging.

Comment by Ivo Kurzemnieks [ 2014 Aug 26 ]

Fixed in pre-2.3.4 (trunk) r48435

Generated at Fri Mar 29 17:02:31 EET 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.