[ZBX-8391] zabbix_get ignores unknown data passed Created: 2014 Jun 25 Updated: 2017 May 30 Resolved: 2015 Mar 27 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Agent (G), Proxy (P), Server (S) |
Affects Version/s: | 2.2.4 |
Fix Version/s: | 2.5.0 |
Type: | Incident report | Priority: | Minor |
Reporter: | richlv | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | validation | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Description |
zabbix_get (and possibly other utilities) does not complain about unknown parameters passed to it : zabbix_get -s 127.0.0.1 -k vfs.fs.size / here, trailing '/' is simply ignored |
Comments |
Comment by Andris Mednis [ 2014 Jul 17 ] |
A stronger command line parameter validation is being developed for all utilities (zabbix_get, zabbix_sender, zabbix_agent, zabbix_agentd, zabbix_proxy, zabbix_server). The validation assumes that:
Also man-pages are being revised and their formatting improved. |
Comment by Andris Mednis [ 2014 Jul 17 ] |
(1) Document zabbix_agentd option "-m" (multiple-agents). This option is enabled only on MS Windows. andris Documented at
<dimir> CLOSED |
Comment by Andris Mednis [ 2014 Aug 06 ] |
Available in development branch svn://svn.zabbix.com/branches/dev/ZBX-8391 . |
Comment by dimir [ 2014 Sep 10 ] |
Successfully tested. Please review my changes in r48928, r48929. andris Thanks! Changes reviewed and accepted. |
Comment by Andris Mednis [ 2014 Sep 15 ] |
Fixed in version pre-2.5.0 r49002. |
Comment by richlv [ 2014 Sep 16 ] |
(2) changelog entry does not follow the guidelines (does not start with a verb in past tense) andris RESOLVED in svn://svn.zabbix.com/trunk r49070. <richlv> thanks, CLOSED |
Comment by richlv [ 2014 Sep 30 ] |
(3) this changes the behaviour, so let's mention it in the upgrade notes andris Documented at https://www.zabbix.com/documentation/3.0/manual/installation/upgrade_notes_300#daemon_changes <richlv> i changed the first sentence a bit. regarding "Help and version messages displayed by command line programs now closer follow GNU recommendations" - we could either list some, or remove that sentence, otherwise it's a bit confusing andris Removed that confusing sentence. <richlv> excellent, thank you - CLOSED |
Comment by Filipp Sudanov (Inactive) [ 2015 Feb 18 ] |
(4) Previously, when using -c zabbix_sender option, hostname was taken from the specified config file. By using optional -s option, hostname value could be overriden. Within this fix -s became non-optional: zabbix_sender [-v] -c config-file -s host -k key -o value that I believe should be changed back. Also the override should probably be mentioned in the man page: <dimir> Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-8391. RESOLVED <sasha> Same problems we have with other options: -z, -I and -p The usage also is incorrect. I think it should be like: zabbix_sender [-v] -z server [-p port] [-I IP-address] -s host -k key -o value zabbix_sender [-v] -z server [-p port] [-I IP-address] [-s host] [-T] [-r] -i input-file zabbix_sender [-v] -c config-file [-z server] [-p port] [-I IP-address] [-s host] -k key -o value zabbix_sender [-v] -c config-file [-z server] [-p port] [-I IP-address] [-s host] [-T] [-r] -i input-file zabbix_sender -h zabbix_sender -V REOPENED <dimir> RESOLVED in r52432 wiper CLOSED |
Comment by dimir [ 2015 Feb 19 ] |
(5) [D] The man page should be updated. I started editing it but then noticed it was generated. As I understood, by richlv. Would be nice if that could be also generated after this issue is tested. <richlv> sender manpage has been regenerated and the date in it synced later -> RESOLVED <dimir> Well done! CLOSED |
Comment by richlv [ 2015 Mar 09 ] |
(6) date in the manpage (see the first line) has not been updated <dimir> RESOLVED in r52622 <richlv> neat, thanks - CLOSED |
Comment by dimir [ 2015 Mar 09 ] |
Support for -I, -z, -p options together with -c and -s option together with -i added back to zabbix_sender in pre-2.5.0 (trunk), r52624. |
Comment by Oleksii Zagorskyi [ 2015 Nov 10 ] |
New style output for -V for java gateway will be done in (1) of ZBX-9824 |