[ZBX-8471] Slide removing from slide show don't work Created: 2014 Jul 15  Updated: 2017 May 30  Resolved: 2014 Jul 24

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.3.3
Fix Version/s: 2.3.3

Type: Incident report Priority: Trivial
Reporter: Oleg Egorov (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: js, slideshows
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File SlideShow.png    

 Description   

1) Open slide show with any slide count
2) Remove 1-2 screens
3) Press "add" and add all screens
4) Try to remove all screens

See SlideShow.png, I try remove last screen, but I can't

No JS error messages.

 Comments   
Comment by Krists Krigers (Inactive) [ 2014 Jul 16 ]

Slide reordering fixed and committed in r47364, branch svn://svn.zabbix.com/branches/dev/ZBX-8471.

Comment by Oleg Egorov (Inactive) [ 2014 Jul 17 ]

(1) String changes?

kristsk No string changes. RESOLVED.

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2014 Jul 17 ]

(2) Coding style:
JS construction

var newStep = (i == 0) ? '0' : i;

var currentStep = jQuery(this).closest('tr').attr('id').split('_')[1];

Better write as

var newStep = (i == 0) ? '0' : i,
        currentStep = jQuery(this).closest('tr').attr('id').split('_')[1];

kristsk RESOLVED in r47560.

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2014 Jul 17 ]

(3) ERROR: Cannot update slide show

Undefined index: slideid [slideconf.php:97 → update_slideshow() in C:\xampp\htdocs\ZBX-8471\frontends\php\include\screens.inc.php:279]
Undefined index: screenid [slideconf.php:97 → update_slideshow() in C:\xampp\htdocs\ZBX-8471\frontends\php\include\screens.inc.php:295]
Error in query [INSERT INTO slides (slideid,slideshowid,screenid,step,delay) VALUES ('188','1','','31','0')] [Cannot add or update a child row: a foreign key constraint fails (`o_trunk/slides`, CONSTRAINT `c_slides_2` FOREIGN KEY (`screenid`) REFERENCES `screens` (`screenid`) ON DELETE CASCADE)]

kristsk RESOLVED in r47576.

oleg.egorov CLOSED

Comment by Oleg Egorov (Inactive) [ 2014 Jul 24 ]

TESTED

Comment by Krists Krigers (Inactive) [ 2014 Jul 31 ]

Fixed and merged to 2.3.3 (trunk) in r47707.

Generated at Tue Apr 23 23:29:22 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.