[ZBX-8543] Remove unnecessary PHP constants Created: 2014 Jul 29 Updated: 2017 May 30 Resolved: 2014 Jul 29 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Frontend (F) |
| Affects Version/s: | 2.3.3 |
| Fix Version/s: | 2.3.3 |
| Type: | Incident report | Priority: | Trivial |
| Reporter: | Pavels Jelisejevs (Inactive) | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | codequality, frontend, php | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
defines.inc.php contains the following constants: define('SBR', "<br/>\n"); These symbols shouldn't be written as constants. SQUAREBRACKETS, SBR and RARR will be rewritten as literal symbols but SPACE will be deprecated |
| Comments |
| Comment by Pavels Jelisejevs (Inactive) [ 2014 Jul 29 ] |
|
RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-8543. |
| Comment by Oleg Egorov (Inactive) [ 2014 Jul 31 ] |
|
(1) String changes: None CLOSED |
| Comment by Oleg Egorov (Inactive) [ 2014 Jul 31 ] |
|
Would be nice to rename → -> ⇒ in CProfiler.php jelisejev These are different symbols, and → looks better in the profiler. |
| Comment by Oleg Egorov (Inactive) [ 2014 Jul 31 ] |
|
TESTED |
| Comment by Pavels Jelisejevs (Inactive) [ 2014 Aug 01 ] |
|
Fixed in 2.3.3 r47726. CLOSED. |