[ZBX-8573] Pre-populated maintenance period values may differ from calendar-populated ones Created: 2014 Aug 03  Updated: 2017 May 30  Resolved: 2014 Sep 05

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.2.4
Fix Version/s: 2.4.0rc1

Type: Incident report Priority: Trivial
Reporter: Marc Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: maintenance, period
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File maintenancePostEdit.png     PNG File maintenancePreEdit.png    

 Description   

Would be nice if result of pre-population and calender selection behaves the same.
I thought there is already a ticket covering this issue but haven't found one.

 Comments   
Comment by Krists Krigers (Inactive) [ 2014 Aug 29 ]

Fixed in r48603, branch svn://svn.zabbix.com/branches/dev/ZBX-8573.

Comment by Ivo Kurzemnieks [ 2014 Sep 01 ]

(1) String changes?

kristsk No string changes. RESOLVED.

iivs CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Sep 01 ]

(2) Manually entering numbers with leading zeros, the zeros are lost during the input.

kristsk RESOLVED in r48638.

iivs

  1. please, describe the function parameters
  2. not sure why we need max number 99 for for date parts. If we use one function, the maximum is 59
  3. also we could make default padding size of 2 to correspond to out date format

REOPENED.

kristsk RESOLVED in r48805.

iivs CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Sep 01 ]

(3) Opening a calendar time should also have leading zeros.

kristsk RESOLVED in r48639.

iivs CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Sep 01 ]

(4) We already have date class in this.sdt, so we can get full date in any format we want. For example we can get full date from calendar like so: 

this.sdt.format('d m Y H i');

the split this date with split(' '); and have one small loop that puts each number in its place.

kristsk RESOLVED in r48639.

iivs Not exactly what I had in mind. I re-factored the code a bit. See r48763

kristsk Re-factoring accepted. Made one additional change. RESOLVED in r48804.

iivs CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Sep 05 ]

(5) I made minor changes in r48818

kristsk CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Sep 05 ]

TESTED,

but close (5) before merging.

Comment by Krists Krigers (Inactive) [ 2014 Sep 05 ]

Fixed and committed to 2.3.6 (trunk) in r48821.

Generated at Thu Apr 25 11:33:21 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.