RESOLVED in r48715. Also added same validation for created triggers and created graphs in r48716. After discussion with jelisejev also added missing validation to allow item.update only for specific fields of created items in r48733.

(1) String changes?

Removed:

• 'Cannot update "%1$s" for a discovered item.'
• 'Cannot update "%1$s" for a discovered trigger.'
• 'Cannot update "%1$s" for a discovered host.'

Added:

• 'Cannot update "%2$s" for a discovered item "%1$s".'
• 'Cannot update "%2$s" for a discovered trigger "%1$s".'
• 'Cannot update "%2$s" for a discovered host "%1$s".'
• 'Cannot delete discovered graph "%1$s".'
• 'Cannot delete discovered item "%1$s".'
• 'Cannot delete discovered trigger "%1$s".'

kristsk RESOLVED.

oleg.egorov Was added

• 'Cannot delete discovered item "%s"!'

Please check other strings

And more

• In the end of message must be dot '.', not '!'
• And %s change to %1$s

REOPENED

kristsk RESOLVED in r49253.

oleg.egorov

• And %s change to %1$s
  Still exist in CGraph.php: 554

And missed dot in CTrigger.php: 588

kristsk RESOLVED in r49458.

oleg.egorov CLOSED

<richlv> the changed string list does not seem to be complete - "Cannot delete discovered item" has been mentioned, but it's final form is not listed.
additionally, string "Cannot delete discovered trigger \"%s\"!" does not seem to be listed at all - and it still ends with an exclamation mark, instead of a dot.

kristsk Fixed 'Cannot delete discovered trigger "%s"!' to 'Cannot delete discovered trigger "%1$s"' in 49824. Updated updated and added string lists. RESOLVED.

sasha REOPENED See (15)

kristsk Removed string 'Cannot delete discovered host "%1$s".' from list via r50401. (15) RESOLVED.

sasha CLOSED

In API requests "output" should be defined as first parameter
This issue exist in CItem.php and CTrigger.php

Thanks, CLOSED

(2) Now CUpdateDiscoveredValidator executed two times
In CItem and CItemGeneral

kristsk RESOLVED in r49020.

oleg.egorov CLOSED

(3) When deleting or updating a discovered object, we must trigger an error.

When updating graphs it must be "Cannot update discovered graph "%graphName%".", for other objects: "Cannot update "field" for a discovered host/trigger/item "%name%"."

When deleting a discovered object the message must be "Cannot delete discovered item/trigger/etc "%name%"."

kristsk RESOLVED in r49230.

oleg.egorov CLOSED

(4) $hostName = (isset($host['host'])) ? $host['host'] : $dbHost['host'];

.. (isset($host['host'])) ...

Is incorrect, should be:

.. isset($host['host']) ...

In CHost.php :569

kristsk RESOLVED in r49273.

oleg.egorov CLOSED

(5) I just try remove host

No permissions to referred object or it does not exist! [hosts.php:639 → CFrontendApiWrapper->delete() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CHost->delete() → CHost->validateDelete() → CHost->checkPermissions() → CApiService::exception() in C:\xampp\htdocs\ZBX-8660\frontends\php\include\classes\api\services\CHost.php:1653]

Host have discovery items, triggers, graphs

kristsk RESOLVED in r49461.

oleg.egorov CLOSED

(6) Don't work host import

Undefined index: hostid [conf.import.php:190 → CFrontendApiWrapper->import() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CConfiguration->import() → CConfigurationImport->import() → CConfigurationImport->processHosts() → CHostImporter->import() → CHost->create() → CHost->checkInput() in C:\xampp\htdocs\ZBX-8660\frontends\php\include\classes\api\services\CHost.php:568]
Undefined variable: dbHosts [conf.import.php:190 → CFrontendApiWrapper->import() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CConfiguration->import() → CConfigurationImport->import() → CConfigurationImport->processHosts() → CHostImporter->import() → CHost->create() → CHost->checkInput() in C:\xampp\htdocs\ZBX-8660\frontends\php\include\classes\api\services\CHost.php:568]

kristsk RESOLVED in r49461.

oleg.egorov CLOSED

(7) Moved code from ::checkPermission() to ::validateUpdate() in r49542. Please check.

oleg.egorov Please remove unnecessary tab in CTrigger.php:851

kristsk RESOLVED in r49545.

oleg.egorov CLOSED

(8) Host delete:

Deleted: Graph "Network traffic on eth0" on "192.168.3.8".
Deleted: Graph "Disk space usage /" on "192.168.3.8".
Graph prototype "Network traffic on

" deleted.
Graph prototype "Disk space usage

" deleted.
Graph prototype "78787" deleted.
Cannot delete discovered trigger "Free disk space is less than 20% on volume /"! [hosts.php:639 → CFrontendApiWrapper->delete() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CHost->delete() → CDiscoveryRule->delete() → CItemPrototype->delete() → CItem->delete() → CTrigger->delete() → CTrigger->validateDelete() → CApiService::exception() in C:\xampp\htdocs\ZBX-8660\frontends\php\include\classes\api\services\CTrigger.php:852]

Cannot delete discovered trigger error

kristsk RESOLVED in r49547.

oleg.egorov CLOSED

TESTED

Merged to 2.5.0 (trunk) in r49583.

(10) Trying to delete a graph with no write permissions will cause an undefined index in CGraph.php:542:

		if (!$nopermissions) {
			foreach ($graphids as $graphid) {
				$delGraph = $delGraphs[$graphid];

kristsk RESOLVED in r49614.

sasha REOPENED

• Development branch should be recreated when it already has been merged.
• Condition if ($delGraph['templateid']) should be replaced by if ($delGraph['templateid'] != 0)

kristsk RESOLVED in r49619, created new branch svn://svn.zabbix.com/branches/dev/ZBX-8660.

sasha CLOSED

Merged to 2.5.0 (trunk) in r49652.

(11) Mass update item causes "Undefined index":

Undefined index: name [items.php:692 → CFrontendApiWrapper->update() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CItem->update() → CItem->validateUpdate() → CItemGeneral->checkInput() in include/classes/api/services/CItemGeneral.php:184]
Updated: Item "Agent ping 1" on "host".
Undefined index: name [items.php:692 → CFrontendApiWrapper->update() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CItem->update() → CItem->validateUpdate() → CItemGeneral->checkInput() in include/classes/api/services/CItemGeneral.php:184]
Updated: Item "Agent ping 2" on "host".

kristsk RESOLVED in r49668, in new branch svn://svn.zabbix.com/branches/dev/ZBX-8660 (copy of trunk).

sasha REOPENED

Calls of CUpdateDiscoveredValidator() methods should be after call of extendObjects()

sasha Sorry, my fail. WON'T FIX

CLOSED

subissues still open : 1, 11

Issues fixed and merged to 2.5.0 in r49845.

(13) regression in r49583 :
edit item on template. it is edited on the that template only, not on any of the downstream hosts/templates

kristsk RESOLVED in r49933, new branch svn://svn.zabbix.com/branches/dev/ZBX-8660 (copy of trunk).

oleg.egorov CLOSED

(14) CItems.php
function update

Unnecessary "hostid" in

$dbItems = $this->get(array(
			'output' => array('itemid', 'hostid', 'flags'),
...

kristsk RESOLVED in r50040.

oleg.egorov CLOSED

TESTED

Fixed and merged to 2.5.0 (trunk) in r50225.

(15) Deleting of the discovered hosts is prohibited. Why? It is excellent functionality supported by frontend!

kristsk Must have misunderstood explanation that discovered entities (hosts included) can only be removed by "un-discovering" them. Removed validation prohibiting delete of discovered hosts. RESOLVED in r50401 in new branch svn://svn.zabbix.com/branches/dev/ZBX-8660 (copy of trunk).

sasha CLOSED

Fixed and merged to 2.5.0 (trunk) in r50480.