[ZBX-8693] IE11 error in Configuration->Trigger->Add page Created: 2014 Sep 01 Updated: 2017 May 30 Resolved: 2014 Oct 20 |
|
Status: | Closed |
Project: | ZABBIX BUGS AND ISSUES |
Component/s: | Frontend (F) |
Affects Version/s: | 2.2.7, 2.3.5 |
Fix Version/s: | 2.0.14rc1, 2.2.8rc1, 2.4.2rc1, 2.5.0 |
Type: | Incident report | Priority: | Major |
Reporter: | Oleg Egorov (Inactive) | Assignee: | Unassigned |
Resolution: | Fixed | Votes: | 0 |
Labels: | IE | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Attachments: | IE11.png |
Description |
Issue exist in 2.2 and 2.4(trunk) Console error message: |
Comments |
Comment by Arvids Godjuks (Inactive) [ 2014 Sep 24 ] |
With IE11 and forward the document.selection object is not present anymore, you need to use the document.getSelection() |
Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 24 ] |
(1) The error is gone, but it seems that this code is left from some partially implemented feature that doesn't work right now (and in all releases starting from 1.8, for that matter). I guess the code that tries to put the current selection in the popup window should be removed. [arvids] Resolved in r49344 jelisejev CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 24 ] |
(2) We also have code that manipulates these selections in configuration.triggers.expression.js.php insertText(). It should be removed as well. [arvids] Resolved in r49345 jelisejev CLOSED. |
Comment by Arvids Godjuks (Inactive) [ 2014 Sep 25 ] |
Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-8693 |
Comment by Arvids Godjuks (Inactive) [ 2014 Sep 25 ] |
(3) No translation changes jelisejev CLOSED. |
Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 25 ] |
(4) I've made a minor change in r49358, to avoid passing javascript in the $data['expression_field_params'] variable. Please review. arvids.godjuks CLOSED |
Comment by Pavels Jelisejevs (Inactive) [ 2014 Sep 25 ] |
TESTED. Please review and close (4) before merging. |
Comment by Arvids Godjuks (Inactive) [ 2014 Sep 25 ] |
Fixed in 2.5.0 (trunk) r49363 |
Comment by Arvids Godjuks (Inactive) [ 2014 Sep 26 ] |
Updated ChangeLog in 2.5.0 (trunk) with r49411 |
Comment by Arvids Godjuks (Inactive) [ 2014 Sep 26 ] |
CLOSED |
Comment by richlv [ 2014 Oct 17 ] |
(5) changelog message appears both in 2.5 and 2.4 sections - i believe it should not be listed in the 2.5 section arvids.godjuks RESOLVED in 2.5.0 (trunk) with r50026 sasha CLOSED |