Fixed in r48957, branch svn://svn.zabbix.com/branches/dev/ZBX-8698. Also moved host list output code to a view, as discussed with jelisejev.
(1) String changes?
kristsk RESOLVED. No string changes.
iivs CLOSED.
(2) The same goes for the "clone" form.
kristsk RESOLVED in r49473.
jelisejev CLOSED.
(3) Paging no longer works in the host list.
kristsk RESOLVED in r49464.
jelisejev In hosts.php:847 "'limit' => $config['search_limit'] + 1" is not required, it only selects hosts that are displayed on the current page.
kristsk RESOLVED in r49628.
jelisejev CLOSED.
(4) In hosts.php:
$data['form'] = getRequest('form', 1);
The form property cannot have a default value of 1.
kristsk RESOLVED in r49465.
jelisejev It shouldn't have a default value at all. It's always present in the request.
kristsk RESOLVED in r49629.
jelisejev CLOSED.
(5) In hosts.php: it's better to use "preservekeys" instead of using zbx_toHash() in "'templates' => zbx_toHash($templates, 'templateid'),"
kristsk REOLVED in r49466, r49467.
jelisejev CLOSED.
(6) Proxies are no longer displayed in the host list.
kristsk RESOLVED in r49468.
jelisejev CLOSED.
(7) Templates linked to the templates linked to hosts are no longer displayed.
kristsk RESOLVED in r49467.
jelisejev CLOSED.
(8) Coding style issue: braces should be closed on the same indentation level as they are open. That is,
$frmForm->addItem(new CDiv(array( new CSubmit('form', _('Create host')), new CButton('form', _('Import'), 'redirect("conf.import.php?rules_preset=host")') )));
instead of
$frmForm->addItem(new CDiv(array( new CSubmit('form', _('Create host')), new CButton('form', _('Import'), 'redirect("conf.import.php?rules_preset=host")') )));
kristsk RESOLVED in r49469.
jelisejev CLOSED.
(9) While you're at it, could you please remove the usages of the SPACE constant?
kristsk RESOLVED in r49470.
jelisejev You've replaced it with spaces, but in some cases we just need to render an empty tag, no spaces required there. Also, in template list the space between the "Unlink" and "Unlink and clear" buttons became smaller. Please restore it using CSS and remove the duplicate spaces.
kristsk RESOLVED in r49630.
- The space between the "reset" and "filter" buttons became smaller in the host list
- The "first" class name is to ambiguous, can you rename it to something more specific, like "link-menu-first"? Also, keep in mind that it may also be used for multiple buttons, so may be it would be better to name it "link-menu-margin"?
kristsk Fixed CSS class name in r49818. As discussed - solution for spacing between "Filter" and "Reset" buttons is not yet decided.
jelisejev Please have a look at the suggested fix for the filter buttons in r49835. I've also restored the missing class in 49836.
kristsk Looks good. CLOSED.
iivs Not sure how that spacing was resoved via css, but buttons still look clumped together.
REOPENED.
iivs RESOLVED in r51108
oleg.egorov CLOSED
TESTED.
(11) Since part of hosts.php code has moved to view configuration.host.list.php ,there will be some conflicting code with changes made in https://support.zabbix.com/browse/ZBXNEXT-2602 , the new buttons will no longer use useJQueryStyle('main');, will have to use proper filter button classes and so on. Let's merge from trunk and resolve any possible conflicts just in case.
Also configuration.host.list.php is missing copyright block at the top.
kristsk RESOLVED in r50895.
iivs CLOSED.
(12) Widget block (DIV tag) should be formed in view just like all other HTML tags, not controller.
iivs RESOLVED in r51108
oleg.egorov CLOSED
(13) In Template -> Full clone still available select "Unlink and clear"
iivs RESOLVED in r51453
oleg.egorov CLOSED
(15) Now in host and templates is different code. And in templates exist host group issue (not ZBX-8698 issue)
Configuration->Templates->Select group(for example "templates")>Create>Selected "templates", but select more groups, for example "templates2">Save>Incorrect value for field "Template name": cannot be empty. And selected 2 groups. That ok->Remove "templates" and again press "save"->"templates" group again still selected.
And code...
In configuration.template.edit.php:79
if ($data['groupId']) {
In the new places we use != 0
And in this file minor coding style improvement.
Please remove 508 line
iivs RESOLVED in r51458
oleg.egorov CLOSED
TESTED
- "Unlink and clear" button will no longer appear when cloning and full cloning host or template. It is because we are in fact creating a new host or template.
- The spacing between "Name" and "Action" in template edit form is also fixed same way they are displayed in hosts.
Fixed in pre-2.5.0 (trunk) r51462
(16) SQL errors on Administration -> Users -> Create user form:
pg_query(): Query failed: ERROR: invalid input syntax for integer: "" LINE 1: ...,m.sendto,m.severity,m.active FROM media m WHERE m.userid='' ^ [users.php:370 → getUserFormData() → DBselect() → pg_query() in include/db.inc.php:395]
Error in query [SELECT m.mediaid,m.mediatypeid,m.period,m.sendto,m.severity,m.active FROM media m WHERE m.userid=''] [ERROR: invalid input syntax for integer: "" LINE 1: ...,m.sendto,m.severity,m.active FROM media m WHERE m.userid='' ^]
iivs RESOLVED in svn://svn.zabbix.com/branches/dev/ZBX-8698 r51741, r51767
sasha TESTED Take a look at my changes in r51774:51778
iivs Thanks! I also corrected $userId still being NULL in getUserFormData() in r51786 and removed "config" parameter in other forms as well in r51796. Please, review.
sasha Thanks a lot! CLOSED
Broken create user form is now fixed.
Fixed in pre-2.5.0 (trunk) r51809
for the record, authors were not alphabetically ordered in the changelog entry, changed in r52263.
iivs I was told that the order of authors is how much each of them contributed, starting from the one who did the most work.
<richlv> that is not correct since at least zabbix 1.8... see https://www.zabbix.org/wiki/Docs/specs/development_guidelines#ChangeLog
besides, i would love to see all the bickering about who contributed most... not.
<sasha> RESOLVED in r52263 by richlv
CLOSED