[ZBX-8761] Potential lockup if signal is received during message logging Created: 2014 Sep 16 Updated: 2021 Jan 07 Resolved: 2014 Sep 30 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Agent (G), Proxy (P), Server (S) |
| Affects Version/s: | None |
| Fix Version/s: | 2.5.0 |
| Type: | Incident report | Priority: | Major |
| Reporter: | Igors Homjakovs (Inactive) | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | logging | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
There is a potential lockup if signal is received during message logging - as it will try to lock the mutex already locked by log function. Possible solution would be to block signals during log writes, but need to check performance impact and how it would work from signal handler itself. |
| Comments |
| Comment by Igors Homjakovs (Inactive) [ 2014 Sep 16 ] |
|
Fixed in svn://svn.zabbix.com/branches/dev/ZBX-8761 |
| Comment by Andris Zeila [ 2014 Sep 17 ] |
|
(1) When using zabbix_log() function in signal handler it can also cause lockups because of localtime() call. It can be fixed by replacing localtime() with localtime_r() in zabbix_log function, but first we must ensure that it is supported by all unix like systems we are supporting (aix, hp-ux, solaris, osx). igorsh RESOLVED in r49475 wiper CLOSED, please review r49503 |
| Comment by Andris Zeila [ 2014 Oct 01 ] |
|
Successfully tested |
| Comment by Igors Homjakovs (Inactive) [ 2014 Oct 10 ] |
|
Fixed in 2.5.0 (r49743) |