[ZBX-8922] "Remove" button in host edit form interfaces is outside border on Firefox 33.0 and Opera 12.x Created: 2014 Oct 17  Updated: 2017 May 30  Resolved: 2014 Dec 01

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Frontend (F)
Affects Version/s: 2.2.6, 2.4.1, 2.5.0
Fix Version/s: 2.5.0

Type: Incident report Priority: Trivial
Reporter: Ivo Kurzemnieks Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: Firefox, Opera, css, design, forms
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows 7

Attachments: PNG File host_edit_form_before_after.png     PNG File interfaces_with_translations.png     PNG File remove_button_outside_border.png     PNG File ukrainian_russian.png    

 Description   

Open host edit form and look at interfaces section.
"Remove" interface button is outside border.
Seen on Firefox 33 and Opera 12.x (Windows)

 Comments   
Comment by Arvids Godjuks (Inactive) [ 2014 Oct 23 ]

Fixed in dev branch svn://svn.zabbix.com/branches/dev/ZBX-8922

Comment by Arvids Godjuks (Inactive) [ 2014 Oct 23 ]

(1) No translation changed

iivs CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Oct 27 ]

(2) Host and host prototype edit forms now look a bit broken. See https://support.zabbix.com/secure/attachment/31135/host_edit_form_before_after.png

arvids.godjuks RESOLVED in r50207

iivs Looks ugly in different languages. See https://support.zabbix.com/secure/attachment/31381/interfaces_with_translations.png

REOPENED.

arvids.godjuks RESOLVED in r50520 - changed the layout a bit to accomodate bigger translated strings in short fields

iivs Some "Add" buttons don't have colspans and cause problems in Russian language.
There are also problems in Ukrainian language. See https://support.zabbix.com/secure/attachment/31818/ukrainian_russian.png
Maybe we can change table width dynamically using JS? Because static width will not be an option here. And we don't want to make a full re-design from <table> to <div> right now.
REOPENED.

iivs Russian is easy to fix (already done locally), but Ukrainian... The label for the "Connect to" is just too wide to, the form will look ridiculous if we stretch it to fit Ukrainian. I can remove the "word-wrap: none" from the properties - it will allow the form to remain uniform and not stretch under extremely long words.

arvids.godjuks RESOLVED in r50917
Fixed colspans and removed the word-wrap: nowrap so that under Ukrainian language the title for the "Connect to" is wrapping. I have checked all other enabled languages and most of disabled - Ukrainian is the only that has this issue, so removal of the word-wrap is preferable to injecting JS and doing UI re-calibration with it.

iivs CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Oct 27 ]

(3) Since we now use css with fixed widths for input fields, let's remove "size" attribute.
arvids.godjuks RESOLVED in r50207

iivs CLOSED.

Comment by Ivo Kurzemnieks [ 2014 Dec 01 ]

TESTED.

Comment by Arvids Godjuks (Inactive) [ 2014 Dec 01 ]

Merged to 2.5.0 (trunk) in r50935

Generated at Fri Apr 26 11:23:07 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.