Fixed in dev branch svn://svn.zabbix.com/branches/dev/ZBX-8943

(1) No translation changes

iivs CLOSED.

(2)

1. Error in script edit form:

       Undefined index: name [scripts.php:70 → CFrontendApiWrapper->get() → CApiWrapper->__call() → CFrontendApiWrapper->callMethod() → CApiWrapper->callMethod() → CFrontendApiWrapper->callClientMethod() → CLocalApiClient->callMethod() → call_user_func_array() → CScript->get() in C:\Development\ZBX-8943-test\frontends\php\include\classes\api\services\CScript.php:163]

2. Slash escaping should be done when sorting by name, but API still should return non-escaped names. Slash escaping should be done on client side.

arvids.godjuks RESOLVED in r50206.
Sort is happening at the PHP level, so I moved the backslash filtering to the same place where the sorting is done.

iivs CLOSED.

(3) No changes in monitoring section. Sorting still boges b->z->a
arvids.godjuks RESOLVED in r50206 - added backslash trimming at the start and end of the string

iivs Tried various strings with slashes and got unexpected results. All slashes at the beginning and end are esaped. A backslash means that the next following symbol should be treated like normal symbol. It means if I enter name "\\a\b" the result should be "\ab" not "ab". If I enter name with "\/" the name is "/", not empty string which breaks the menu popup. Similarly with "d
", "d\\\", both return same name "d", which is not correct.

REOPENED.

arvids.godjuks RESOLVED in r50556

sasha Backslashes are removed not in all cases, for example:

\ac\/\a => ac/\a

REOPENED

arvids.godjuks RESOLVED in r50597

iivs Coding style:
func.inc.php splitPath()

• Avoid using such assignments $escapeCharacters = $pathItemString = '';
• Comments are not following guidelines - sentences must end with a dot.
• Integers must not use strict comparison.

REOPENED.

arvids.godjuks RESOLVED in r50918

iivs I fixed coding style in several other lines of code. Please see my changes in r50933

arvids.godjuks CLOSED

(4) Slash escaping and sorting is not covered in maps.

arvids.godjuks RESOLVED in r50558

iivs CLOSED.

(5) backslashes should not be removed by API when creating or updating a script

arvids.godjuks RESOLVED in r50597

sasha CLOSED

TESTED,
but don't forget to close (3).

Merged to 2.5.0 (trunk) in r50937

(6) Administration->Scripts
Name: <Sub-menu/Sub-menu.../>Script

Result:

sasha It's broken under ZBXNEXT-2073 in version 2.3.0. Moved to ZBX-9203.

CLOSED