[ZBX-9279] Reduce amount of data retrieved by vmware collector Created: 2015 Feb 03  Updated: 2017 May 30  Resolved: 2015 Feb 09

Status: Closed
Project: ZABBIX BUGS AND ISSUES
Component/s: Proxy (P), Server (S)
Affects Version/s: None
Fix Version/s: 2.2.9rc1, 2.4.4rc1, 2.5.0

Type: Incident report Priority: Trivial
Reporter: Andris Zeila Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: performance, vmware
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File vmware-optimized-requests.diff    

 Description   

Currently vmware collector retrieves object top level properties - for example overallStatus, name, vm, summary, parent, datastore are retrieved for hypervisors. However often we really need only a subset of retrieved data. For example we aren't using summary/runtime, which is quite large. So instead of retrieving whole summary property we should specify detalized property paths:

            <urn:propSet>
               <urn:type>HostSystem</urn:type>
               <urn:pathSet>overallStatus</urn:pathSet>
               <urn:pathSet>name</urn:pathSet>
               <urn:pathSet>vm</urn:pathSet>
               <urn:pathSet>summary.quickStats</urn:pathSet>
               <urn:pathSet>summary.config</urn:pathSet>
               <urn:pathSet>summary.hardware</urn:pathSet>
               <urn:pathSet>parent</urn:pathSet>
               <urn:pathSet>datastore</urn:pathSet>
            </urn:propSet>

The attached patch provides simple optimization, recuding the amount of retrieved data by 50%

 Comments   
Comment by Andris Zeila [ 2015 Feb 04 ]

(1) In vmware_service_update_perf() function entities vector is initialized in two places. The first zbx_vector_ptr_create(&entities) should be removed.

RESOLVED

sasha CLOSED

Comment by Andris Zeila [ 2015 Feb 05 ]

Fixed in development branch svn://svn.zabbix.com/branches/dev/ZBX-9279

Comment by Alexander Vladishev [ 2015 Feb 06 ]

(2) vmware.hv.status[{$URL},{HOST.HOST}] reports different data

Before the fix:

  • gray (0)

After:

  • green (1)

Related issue: ZBX-7446

sasha REOPENED

wiper RESOLVED in r52063

sasha CLOSED

Comment by Andris Zeila [ 2015 Feb 09 ]

(3) Memory leak during first authentication at vmware.c:958:

		if (NULL == (*error = zbx_xml_read_value(page.data, ZBX_XPATH_FAULTSTRING())))

wiper RESOLVED in r52064

sasha CLOSED

Comment by Andris Zeila [ 2015 Feb 09 ]

Released in:

  • pre-2.2.9rc1 r52083
  • pre-2.4.4rc1 r52084
  • pre-2.5.0 r52086
Comment by Andris Zeila [ 2015 Feb 09 ]

(4) Documentation:

wiper RESOLVED

sasha CLOSED

Generated at Thu May 02 00:43:39 EEST 2024 using Jira 9.12.4#9120004-sha1:625303b708afdb767e17cb2838290c41888e9ff0.