[ZBX-9592] Error message is incorrect for PdhMakeCounterPath() Created: 2015 May 27 Updated: 2017 May 30 Resolved: 2015 Aug 19 |
|
| Status: | Closed |
| Project: | ZABBIX BUGS AND ISSUES |
| Component/s: | Agent (G) |
| Affects Version/s: | 2.2.9 |
| Fix Version/s: | 2.0.16rc1, 2.2.10rc1, 2.4.6rc1, 2.5.0 |
| Type: | Incident report | Priority: | Blocker |
| Reporter: | Kodai Terashima | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | agent, logging, windows | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Description |
|
the variable "counterpath" is not defined for log error output in zbx_PdhMakeCounterPath() src/libs/zbxwin32/perfmon.c PDH_STATUS zbx_PdhMakeCounterPath(const char *function,
if (ERROR_SUCCESS != (pdh_status = PdhMakeCounterPath(cpe, wcounterPath, &dwSize, 0)))
{
zabbix_log(LOG_LEVEL_ERR, "%s(): cannot make counterpath '%s': %s",
function, counterpath, strerror_from_module(pdh_status, L"PDH.DLL"));
}
zbx_unicode_to_utf8_static(wcounterPath, counterpath, PDH_MAX_COUNTER_PATH);
}
It seems that the error output shows incorrect counter path. |
| Comments |
| Comment by Alexander Vladishev [ 2015 May 27 ] |
|
Seems, it can cause an agent crash. Priority changed to "Blocker". |
| Comment by Igors Homjakovs (Inactive) [ 2015 May 28 ] |
|
Fixed in svn://svn.zabbix.com/branches/dev/ZBX-9592 |
| Comment by Aleksandrs Saveljevs [ 2015 May 28 ] |
|
Looks good, but please see r53846 for a bit of style before merging. |
| Comment by Igors Homjakovs (Inactive) [ 2015 May 29 ] |
|
Available in 2.0.15rc1 r53853, 2.2.10rc1 r53854, 2.4.6rc1 r53855 and 2.5.0 (trunk) r53856. |